| Summary: | REST API tests do not clean up | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | REST API | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, lari.taskula, ldjamison, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18826: rollback transaction for api tests
[SIGNED-OFF] Bug 18826: rollback transaction for api tests Bug 18826: rollback transaction for api tests Bug 18826 - (QA Followup) Add mock SessionStorage to patrons.t |
||
|
Description
Jonathan Druart
2017-06-19 20:05:44 UTC
Created attachment 65012 [details] [review] Bug 18826: rollback transaction for api tests The holds.t tests for the REST api do no rollback properly and modify the DB (no cleanup). This comes from a bug caused by SessionStorage = mysql (default) The error is: "rollback ineffective with AutoCommit enabled" Test plan: select count(*) from borrowers; prove t/db_dependent/api/v1/holds.t select count(*) from borrowers; => The number of entry must be the same before and after the tests have been executed Created attachment 65143 [details] [review] [SIGNED-OFF] Bug 18826: rollback transaction for api tests The holds.t tests for the REST api do no rollback properly and modify the DB (no cleanup). This comes from a bug caused by SessionStorage = mysql (default) The error is: "rollback ineffective with AutoCommit enabled" Test plan: select count(*) from borrowers; prove t/db_dependent/api/v1/holds.t select count(*) from borrowers; => The number of entry must be the same before and after the tests have been executed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 65177 [details] [review] Bug 18826: rollback transaction for api tests The holds.t tests for the REST api do no rollback properly and modify the DB (no cleanup). This comes from a bug caused by SessionStorage = mysql (default) The error is: "rollback ineffective with AutoCommit enabled" Test plan: select count(*) from borrowers; prove t/db_dependent/api/v1/holds.t select count(*) from borrowers; => The number of entry must be the same before and after the tests have been executed Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 65178 [details] [review] Bug 18826 - (QA Followup) Add mock SessionStorage to patrons.t Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.02. These patches have been pushed to 16.11.x and will be in 16.11.10. |