Summary: | Managing Suggestions - authorised list of reasons why patron requesting book | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice |
Version: | Main | ||
Hardware: | Macintosh | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 27230 | ||
Attachments: |
originally i thought that SUGGEST was for the user - and I came up with this list
1 - approved suggestion 2 - order from vendor 3 - order from suggestion Proposed fix Proposed fix ( revised) Follow-up fix solve comment 10 |
Description
Chris Cormack
2010-05-21 00:35:43 UTC
Created attachment 2809 [details] [review] Proposed fix Fix for Bug 1883, authorised list of reasons why patron requesting book - Adding form controls to opac submission form and staf client edit form. - Adding display of patron reason for suggestion on opac list - Adding function for pulling an authorized value description using the category and value TODO: Add some default authorised values Note for testers: my proposed fix uses an authorized value with the code "OPAC_SUG." Created attachment 2828 [details] [review] Proposed fix ( revised) Part of proposed fix is already in master from a previously applied patch (changes in C4/Koha.pm) Removed the duplication so patch applies cleanly on current master Pushed, please test This works, but the auth val category 'OPAC_SUG' doesn't get created on upgrade and there is no hint anywhere that this authorized value is available. I'll add it to the manual, but we should also add it on upgrade or include some sort of sample data for it. This bug is mentioned in: Fix for Bug 1883, authorised list of reasons why patron requesting book http://lists.koha-community.org/pipermail/koha-patches/2010-December/013177.html Fix for Bug 1883, authorised list of reasons why patron requesting book http://lists.koha-community.org/pipermail/koha-patches/2010-December/013227.html I can submit a patch which would add a couple of default suggestion reasons via updatedatabase.pl: INSERT INTO authorised_values (category,authorised_value,lib,lib_opac) VALUES ('OPAC_SUG','damaged','The copy on the shelf is damaged','The copy on the shelf is damaged INSERT INTO authorised_values (category,authorised_value,lib,lib_opac) VALUES ('OPAC_SUG','bestseller','Upcoming title by popular author','Upcoming title by popular author Anyone have objections or suggestions? That would be great! Created attachment 3088 [details] [review] Follow-up fix Adds two default authorized values in the category OPAC_SUG: damaged, "The copy on the shelf is damaged" bestseller, "Upcoming title by popular author" (In reply to comment #9) > Created attachment 3088 [details] [review] > Follow-up fix > > Adds two default authorized values in the category OPAC_SUG: > > damaged, "The copy on the shelf is damaged" > bestseller, "Upcoming title by popular author" This patch added these types only on upgrade. We need them to be added to new installs to. Created attachment 3195 [details] [review] solve comment 10 Patch pushed, please test This bug is mentioned in: Bug 1883 follow-up: Adding default OPAC_SUG values http://lists.koha-community.org/pipermail/koha-patches/2011-February/013777.html |