|Summary:||Managing Suggestions - authorised list of reasons why patron requesting book|
|Product:||Koha||Reporter:||Nicole C. Engard <nengard>|
|Component:||Acquisitions||Assignee:||Owen Leonard <oleonard>|
|Status:||CLOSED FIXED||QA Contact:||Bugs List <koha-bugs>|
|Priority:||PATCH-Sent (DO NOT USE)||CC:||chris, julian.maurice, katrin.fischer|
|Change sponsored?:||---||Patch complexity:||---|
|Documentation contact:||Documentation submission:|
|Text to go in the release notes:||Version(s) released in:|
|Bug Depends on:|
originally i thought that SUGGEST was for the user - and I came up with this list
1 - approved suggestion
2 - order from vendor
3 - order from suggestion
Proposed fix ( revised)
solve comment 10
Description Chris Cormack 2010-05-21 00:35:43 UTC
Comment 1 Owen Leonard 2010-12-06 16:50:24 UTC Comment hidden (obsolete)
Created attachment 2809 [details] [review] Proposed fix Fix for Bug 1883, authorised list of reasons why patron requesting book - Adding form controls to opac submission form and staf client edit form. - Adding display of patron reason for suggestion on opac list - Adding function for pulling an authorized value description using the category and value TODO: Add some default authorised values
Comment 2 Owen Leonard 2010-12-06 16:52:17 UTC
Note for testers: my proposed fix uses an authorized value with the code "OPAC_SUG."
Comment 3 Colin Campbell 2010-12-10 14:59:22 UTC
Created attachment 2828 [details] [review] Proposed fix ( revised) Part of proposed fix is already in master from a previously applied patch (changes in C4/Koha.pm) Removed the duplication so patch applies cleanly on current master
Comment 4 Chris Cormack 2010-12-12 21:11:13 UTC
Pushed, please test
Comment 5 Nicole C. Engard 2010-12-16 15:07:00 UTC
This works, but the auth val category 'OPAC_SUG' doesn't get created on upgrade and there is no hint anywhere that this authorized value is available. I'll add it to the manual, but we should also add it on upgrade or include some sort of sample data for it.
Comment 6 MJ Ray (software.coop) 2011-01-08 11:13:29 UTC
This bug is mentioned in: Fix for Bug 1883, authorised list of reasons why patron requesting book http://lists.koha-community.org/pipermail/koha-patches/2010-December/013177.html Fix for Bug 1883, authorised list of reasons why patron requesting book http://lists.koha-community.org/pipermail/koha-patches/2010-December/013227.html
Comment 7 Owen Leonard 2011-02-04 16:47:38 UTC
I can submit a patch which would add a couple of default suggestion reasons via updatedatabase.pl: INSERT INTO authorised_values (category,authorised_value,lib,lib_opac) VALUES ('OPAC_SUG','damaged','The copy on the shelf is damaged','The copy on the shelf is damaged INSERT INTO authorised_values (category,authorised_value,lib,lib_opac) VALUES ('OPAC_SUG','bestseller','Upcoming title by popular author','Upcoming title by popular author Anyone have objections or suggestions?
Comment 8 Nicole C. Engard 2011-02-04 17:38:46 UTC
That would be great!
Comment 9 Owen Leonard 2011-02-07 20:56:24 UTC
Created attachment 3088 [details] [review] Follow-up fix Adds two default authorized values in the category OPAC_SUG: damaged, "The copy on the shelf is damaged" bestseller, "Upcoming title by popular author"
Comment 10 Nicole C. Engard 2011-02-08 00:11:02 UTC
(In reply to comment #9) > Created attachment 3088 [details] [review] > Follow-up fix > > Adds two default authorized values in the category OPAC_SUG: > > damaged, "The copy on the shelf is damaged" > bestseller, "Upcoming title by popular author" This patch added these types only on upgrade. We need them to be added to new installs to.
Comment 11 Paul Poulain 2011-02-22 20:59:16 UTC
Created attachment 3195 [details] [review] solve comment 10
Comment 12 Chris Cormack 2011-02-27 21:45:06 UTC
Patch pushed, please test
Comment 13 MJ Ray (software.coop) 2011-03-05 10:34:13 UTC
This bug is mentioned in: Bug 1883 follow-up: Adding default OPAC_SUG values http://lists.koha-community.org/pipermail/koha-patches/2011-February/013777.html