Summary: | Have "actions" at both ends of the circulation rules table | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | System Administration | Assignee: | Liz Rea <liz> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, guillaume_lair, jonathan.druart, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 19539 | ||
Attachments: |
Bug 18857 - Add buttons to left hand side of circ rules table
Bug 18857 - Add buttons to left hand side of circ rules table Bug 18857 - Add buttons to left hand side of circ rules table Bug 18857 (QA Followup) Add title to lower 'Action' header |
Description
Liz Rea
2017-06-26 23:42:14 UTC
Created attachment 64663 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) On circ rules table we have used successfully buttons to left hand side to change some existing values, add and delete a new patron category. Patch tested with a sandbox, by Guillaume <guillaume_lair@ville-limoges.fr> Created attachment 64700 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume <guillaume_lair@ville-limoges.fr> Created attachment 65340 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume <guillaume_lair@ville-limoges.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 65341 [details] [review] Bug 18857 (QA Followup) Add title to lower 'Action' header These were showing as blank, for consistency seems like we should label as 'Actions' I disagree with Nick's change, it isn't how the column is labelled currently and I don't see the point to having it in the table footer. Consistency is usually good, there doesn't seem to be much point to it in this case. Cheers, Liz Comment on attachment 65341 [details] [review] Bug 18857 (QA Followup) Add title to lower 'Action' header Will not be pushed, move to its own bug report if you want to discuss more about it. Pushed to master for 17.11, thanks to everybody involved! awesome thank you Jonathan! Enhancement not pushed to 17.05.x |