Bug 18859

Summary: Warns when accessing Circulation -> Holds Queue
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: CirculationAssignee: Aleisha Amohia <aleisha>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, m.de.rooy, veron
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18859: Prevent warns when viewing holds queue
Bug 18859: Prevent warns when viewing holds queue

Description Aleisha Amohia 2017-06-27 01:47:46 UTC
Viewing the holds queue triggers the following warns:
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69.
Comment 1 Aleisha Amohia 2017-06-27 01:49:51 UTC
Created attachment 64666 [details] [review]
Bug 18859: Prevent warns when viewing holds queue

The code was using $itemtypes->description instead of
$itemtype->description.

To test:
1) View the intranet log
2) Go to Circulation -> Holds queue
3) Notice the warns
4) Apply patch and refresh page
5) Warns should not appear and item types should still display as
expected

Sponsored-by: Catalyst IT
Comment 2 Marc Véron 2017-06-29 14:14:58 UTC
Created attachment 64725 [details] [review]
Bug 18859: Prevent warns when viewing holds queue

The code was using $itemtypes->description instead of
$itemtype->description.

To test:
1) View the intranet log
2) Go to Circulation -> Holds queue
3) Notice the warns
4) Apply patch and refresh page
5) Warns should not appear and item types should still display as
expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Marcel de Rooy 2017-07-03 07:49:34 UTC
Good catch, Aleisha.
I am moving the solution to 18881 as Marc expanded it.

*** This bug has been marked as a duplicate of bug 18881 ***