Bug 18872

Summary: Clicking "Place hold" on catalogue/detail.pl triggers software error if any items have NULL homebranch
Product: Koha Reporter: Barton Chittenden <barton>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Barton Chittenden 2017-06-28 11:47:39 UTC
To re-create:

1) Create several items. Set homebranch to NULL on one of the items.
2) Go to the detail page for the bib record. Click "Place Hold".
3) This will trigger a software error. Here are the results from the logs:

Use of uninitialized value in hash element at /usr/share/koha/intranet/cgi-bin/reserve/request.pl line 362.
Use of uninitialized value in hash element at /usr/share/koha/intranet/cgi-bin/reserve/request.pl line 363.
Use of uninitialized value in string ne at /usr/share/koha/intranet/cgi-bin/reserve/request.pl line 368.
Use of uninitialized value in string ne at /usr/share/koha/intranet/cgi-bin/reserve/request.pl line 368.
item-level_itypes set but no itemtype set for item (762357) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698.
No homebranch at /usr/share/koha/lib/C4/Reserves.pm line 2121.
Comment 1 Katrin Fischer 2019-02-10 19:18:26 UTC
I think it was agreed to not fix these kind of errors. The problem is the data - items always need to have an itemtype, homebranch and holdingbranch.
Comment 2 Katrin Fischer 2020-01-11 21:40:49 UTC
(In reply to Katrin Fischer from comment #1)
> I think it was agreed to not fix these kind of errors. The problem is the
> data - items always need to have an itemtype, homebranch and holdingbranch.