| Summary: | Add unique constraint to repeatable_holidays and special_holidays | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> | 
| Component: | Tools | Assignee: | Bugs List <koha-bugs> | 
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> | 
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | barton, ldjamison, mtompset, nick, victor | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 18874: Add unicity constraint Bug 18874: Add unicity constraint | ||
| 
        
          Description
        
        
          Baptiste Wojtkowski (bwoj)
        
        
        
        
          2017-06-28 14:30:57 UTC
        
       Created attachment 64705 [details] [review] Bug 18874: Add unicity constraint Baptiste, please provide a test plan and I will gladly test! Hi, 1 - Create holiday for a library 2 - Copy this holidays to a second library 3 - Copy these holidays to the first library Check in base, you should have a duplicate 4 - Undo changes 5 - Apply patch 6 - Update database and database schema 7 repeat 1-3, it should not duplicate datas Created attachment 64970 [details] [review] Bug 18874: Add unicity constraint Signed-off-by: Lee Jamison <ldjamison@marywood.edu> This does work, we get errors in the logs with no feedback for user, if the intention is to replace an existing holiday with a different holiday this could be confusing. Perhaps we should perform the check and offer an error/notification? Also, this fails to add the constraint for a fresh install. Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. *** Bug 18520 has been marked as a duplicate of this bug. *** |