| Summary: | Course Reserves still accessible by URL even if turned OFF | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Sassmannshausen <alex> |
| Component: | Circulation | Assignee: | Alex Sassmannshausen <alex> |
| Status: | In Discussion --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | elizabethjohn6654, gmcharlt, jonathan.druart, kyle, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 18902: Disable access to CourseReserves if syspref off.
Bug 18902: Disable access to CourseReserves if syspref off. Bug 18902: Disable access to CourseReserves if syspref off. Bug 18902: Disable access to CourseReserves if syspref off. |
||
|
Description
Alex Sassmannshausen
2017-07-06 15:30:00 UTC
Created attachment 64853 [details] [review] Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Created attachment 64854 [details] [review] Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. Created attachment 65289 [details] [review] Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> It sounds like it would be better to display a message on the staff interface, but not that easy. However do not you think that we need to modify all course_reserves/* scripts? The module may have been enabled then disabled later. Created attachment 65308 [details] [review] Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Jonathan Druart from comment #4) > It sounds like it would be better to display a message on the staff > interface, but not that easy. > However do not you think that we need to modify all course_reserves/* > scripts? > The module may have been enabled then disabled later. This needs an answer (In reply to Jonathan Druart from comment #6) > (In reply to Jonathan Druart from comment #4) > > It sounds like it would be better to display a message on the staff > > interface, but not that easy. > > However do not you think that we need to modify all course_reserves/* > > scripts? > > The module may have been enabled then disabled later. > > This needs an answer Overlooked your comment. (In reply to Elizabeth John from comment #8) Spam |