|
Description
Katrin Fischer
2017-07-08 19:02:04 UTC
I did not implement that on bug 17762 because it's hard to know if all notices have been translated. But indeed it can be hidden with *BorrowerUnwantedField. I think if there is a fallback on the "default" that would still be ok for most libraries. We could also cover it somewhat in the label:. "Preferred language for notices" doesn't necessarily mean that everything is available translated I think. *** Bug 19561 has been marked as a duplicate of this bug. *** I agree with Katrin here. From 17762: "Not the opac because we do not want the patron to modify it, they won't be necessary translated." For library staff it would be much easier if the patron could set it on OPAC. It could be made dependent of the syspref too. So if nothing is translated and the pref is off, you do not raise expectations? Not to mention the unwanted prefs. Any plans here? I think it also falls back to the "Default" message, so they will always receive notices - translated or not. Created attachment 105940 [details] [review] Bug 18911: Add the ability to set the preferred lang for notice at the OPAC Patron should be allowed to modify this setting without asking a staff member. The setting is not configurable and cannot be hidden via a syspref. Test plan: - Turn the pref TranslateNotices on - Install some languages - Edit your messaging settings at the OPAC => Notice the "Preferred language for notices" dropdown list - Select one => Confirm that the value is saved in DB Created attachment 105949 [details] [review] Bug 18911: Add the ability to set the preferred lang for notice at the OPAC Patron should be allowed to modify this setting without asking a staff member. The setting is not configurable and cannot be hidden via a syspref. Test plan: - Turn the pref TranslateNotices on - Install some languages - Edit your messaging settings at the OPAC => Notice the "Preferred language for notices" dropdown list - Select one => Confirm that the value is saved in DB Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 105950 [details] [review] Bug 18911: (follow-up) We should save changes with a POST Test plan: Verify if changes to messaging table and language are still saved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Thanks Jonathan for your quick response. As a side note: We should probably move Preferred language for notices on staff memberentry also to the Messaging preferences section instead of Library management. But this could be done elsewhere. Note also that moremember does not show a language for 'Default'. /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=51&step=5 does not include the patron notice language either, although it is about messaging. Created attachment 105952 [details] [review] Bug 18911: Add the ability to set the preferred lang for notice at the OPAC Patron should be allowed to modify this setting without asking a staff member. The setting is not configurable and cannot be hidden via a syspref. Test plan: - Turn the pref TranslateNotices on - Install some languages - Edit your messaging settings at the OPAC => Notice the "Preferred language for notices" dropdown list - Select one => Confirm that the value is saved in DB Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 105953 [details] [review] Bug 18911: (follow-up) We should save changes with a POST Test plan: Verify if changes to messaging table and language are still saved. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Exchanging signoff with oleonard. Passing QA now ! Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 enhancement, not backported to 19.11.x |