Bug 18917

Summary: Use font awesome buttons in CSV profiles
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: ToolsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, josef.moravec, katrin.fischer
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 8612    
Bug Blocks:    
Attachments: Bug 18917: Use font-awesome buttons for CSV profiles
Bug 18917: Use font-awesome buttons for CSV profiles
Bug 18917: Use font-awesome buttons for CSV profiles

Description Aleisha Amohia 2017-07-10 02:00:48 UTC

    
Comment 1 Aleisha Amohia 2017-07-10 02:13:35 UTC
Created attachment 64944 [details] [review]
Bug 18917: Use font-awesome buttons for CSV profiles

To test:
1) Go to Tools -> CSV profiles
2) Notice old style of links for Edit and Delete
3) Apply patch and refresh page
4) Notice buttons for Edit and Delete
5) Confirm they work as expected

Sponsored-by: Catalyst IT
Comment 2 Lee Jamison 2017-07-10 13:16:54 UTC
Created attachment 64963 [details] [review]
Bug 18917: Use font-awesome buttons for CSV profiles

To test:
1) Go to Tools -> CSV profiles
2) Notice old style of links for Edit and Delete
3) Apply patch and refresh page
4) Notice buttons for Edit and Delete
5) Confirm they work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Patch works as directed and looks great!
Comment 3 Jonathan Druart 2017-07-13 19:43:44 UTC
Created attachment 65028 [details] [review]
Bug 18917: Use font-awesome buttons for CSV profiles

To test:
1) Go to Tools -> CSV profiles
2) Notice old style of links for Edit and Delete
3) Apply patch and refresh page
4) Notice buttons for Edit and Delete
5) Confirm they work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2017-07-13 21:43:46 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin Somers 2017-07-27 14:29:25 UTC
Enhancement not pushed to 17.05.x