Summary: | Fix cleanup in t/db_dependent/Log.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
Component: | Test Suite | Assignee: | Lari Taskula <lari.taskula> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, mtj, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 18991: Fix cleanup in t/db_dependent/Log.t
Bug 18991: Fix cleanup in t/db_dependent/Log.t Bug 18991: Fix cleanup in t/db_dependent/Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback |
Description
Lari Taskula
2017-07-27 14:55:39 UTC
Created attachment 65295 [details] [review] Bug 18991: Fix cleanup in t/db_dependent/Log.t There is an action_logs entry via logaction() without transaction to be rolled back in t/db_dependent/Log.t. This leaves an entry in action_logs after the test is over. To replicate: 1. prove t/db_dependent/Log.t 2. Observe a new entry in action_logs table To test: 1. Apply patch 2. prove t/db_dependent/Log.t 3. Observe there are no new entries in action_logs Created attachment 65300 [details] [review] Bug 18991: Fix cleanup in t/db_dependent/Log.t There is an action_logs entry via logaction() without transaction to be rolled back in t/db_dependent/Log.t. This leaves an entry in action_logs after the test is over. To replicate: 1. prove t/db_dependent/Log.t 2. Observe a new entry in action_logs table To test: 1. Apply patch 2. prove t/db_dependent/Log.t 3. Observe there are no new entries in action_logs Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 65305 [details] [review] Bug 18991: Fix cleanup in t/db_dependent/Log.t There is an action_logs entry via logaction() without transaction to be rolled back in t/db_dependent/Log.t. This leaves an entry in action_logs after the test is over. To replicate: 1. prove t/db_dependent/Log.t 2. Observe a new entry in action_logs table To test: 1. Apply patch 2. prove t/db_dependent/Log.t 3. Observe there are no new entries in action_logs Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 65306 [details] [review] Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback We also need just one rollback at the end here. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.03. These patches have been pushed to 16.11.x and will be in 16.11.11. Pushed to 16.05.x, for 16.05.16 release |