Summary: | Add a TestBuilder default for borrowers.login_attempts | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18314 | ||
Bug Blocks: | |||
Attachments: |
Bug 19003: Fix account lockouts in SIP/Message.t
Bug 19003: Add a TestBuilder default for borrower.login_attempts Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 19003: Add a TestBuilder default for borrowers.login_attempts |
Description
Marcel de Rooy
2017-07-29 15:05:27 UTC
Make it not dependent on pref FailedLoginAttempts Created attachment 65321 [details] [review] Bug 19003: Fix account lockouts in SIP/Message.t Follow-up for bug 18314. Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since testbuilder fills login_attempts with a random number. Trivial fix. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 65328 [details] [review] Bug 19003: Add a TestBuilder default for borrower.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 65329 [details] [review] Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 65342 [details] [review] Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. |