| Summary: | sample_data.sql inserts patrons with guarantorid that do not exist | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, mtj, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql
Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql Bug 19013: (QA followup) Set guarantorid to NULL patron sample data |
||
Created attachment 65374 [details] [review] Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql That breaks randomly tests on Jenkins (Koha/Patrons.t) It certainly affects data in other languages but I did not find a quick and easy way to modify this file (replace all guarantorid values with NULL) Created attachment 65555 [details] [review] Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql That breaks randomly tests on Jenkins (Koha/Patrons.t) It certainly affects data in other languages but I did not find a quick and easy way to modify this file (replace all guarantorid values with NULL) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Easy fix Created attachment 65556 [details] [review] Bug 19013: (QA followup) Set guarantorid to NULL patron sample data Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. These patches have been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |
MariaDB [koha_kohadev]> select borrowernumber, guarantorid from borrowers where guarantorid is not null; +----------------+-------------+ | borrowernumber | guarantorid | +----------------+-------------+ | 6 | 102 | | 7 | 104 | | 8 | 112 | | 15 | 131 | | 18 | 160 | | 21 | 177 | | 30 | 254 | | 35 | 287 | | 36 | 288 | | 37 | 289 | | 40 | 320 | | 42 | 337 | +----------------+-------------+ MariaDB [koha_kohadev]> select max(borrowernumber) from borrowers; +---------------------+ | max(borrowernumber) | +---------------------+ | 50 | +---------------------+ That breaks randomly tests on Jenkins (Koha/Patrons.t) # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 85. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 88. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 95. # got: '3' # expected: '2' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 98. # got: '3' # expected: '2' # Looks like you failed 4 tests of 8. # Failed test 'guarantees' # at t/db_dependent/Koha/Patrons.t line 100. # Failed test 'Delete should have deleted the patron' # at t/db_dependent/Koha/Patrons.t line 905. # got: '51' # expected: '52' # Looks like you failed 2 tests of 22. [16:26:26] t/db_dependent/Koha/Patrons.t ................................