Bug 19033

Summary: XSS Flaws in Currencies and exchange page
Product: Koha Reporter: Amit Gupta <amitddng135>
Component: Architecture, internals, and plumbingAssignee: Amit Gupta <amitddng135>
Status: CLOSED FIXED QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: major    
Priority: P5 - low CC: amitddng135, chris, fridolin.somers, gmcharlt, indradg, jonathan.druart, katrin.fischer, mtj, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 14568    
Attachments: Screenhot XSS currenices page
Bug 19033 - XSS Flaws in Currencies and exchange page
Bug 19033: XSS Flaws in Currencies and exchange page

Description Amit Gupta 2017-08-04 04:02:21 UTC
XSS Flaws in Currencies and exchange page
Comment 1 Amit Gupta 2017-08-04 04:12:02 UTC
Created attachment 65483 [details]
Screenhot XSS currenices page

XSS issue in the Currencies and exchange page
Comment 2 Amit Gupta 2017-08-04 04:19:43 UTC
Created attachment 65484 [details] [review]
Bug 19033 - XSS Flaws in Currencies and exchange page

1. Hit /cgi-bin/koha/admin/currency.pl
2. Enter <IFRAME SRC="javascript:alert('XSS');"></IFRAME> search currencies box.
3. Notice the iframe is executed.
4. Apply patch.
5. Reload page, and enter iframe again on search currencies box.
6. Notice it is no longer executed.
Comment 3 Tomás Cohen Arazi 2017-08-07 14:09:22 UTC
Created attachment 65557 [details] [review]
Bug 19033: XSS Flaws in Currencies and exchange page

1. Hit /cgi-bin/koha/admin/currency.pl
2. Enter <IFRAME SRC="javascript:alert('XSS');"></IFRAME> search currencies box.
3. Notice the iframe is executed
4. Apply patch
5. Reload page, and enter iframe again on search currencies box.
6. Notice it is no longer executed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Fixes the issue, follows common practice on the codebase.
Comment 4 Jonathan Druart 2017-08-29 15:07:13 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin SOMERS 2017-09-05 12:44:37 UTC
Pushed to 17.05.x, is in 17.05.03
Comment 6 Katrin Fischer 2017-09-07 06:14:44 UTC
This patch has been pushed to 16.11.x and is in 16.11.11.
Comment 7 Mason James 2017-09-20 02:38:33 UTC
Pushed to 16.05.x, for 16.05.16 release - thanks Amit :0)