| Summary: | Auto renewal flag is not kept if a confirmation is needed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, julian.maurice, kyle.m.hall, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11577 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 19053: Keep auto_renew flag if a confirmation is needed
[SIGNED-OFF] Bug 19053: Keep auto_renew flag if a confirmation is needed Bug 19053: Keep auto_renew flag if a confirmation is needed |
||
|
Description
Jonathan Druart
2017-08-07 16:50:22 UTC
Created attachment 65588 [details] [review] Bug 19053: Keep auto_renew flag if a confirmation is needed If an item is checked out with the auto renewal flag and a confirmation is needed (holds exist, past due date, etc.) the auto renewal flag will get lost. Test plan: - Check an item out and specify a past due date - Confirm the checkout on the confirmation screen => Without this patch the checkout is not marked as auto renewal => With this patch applied the auto renewal flag will be set to the checkout Created attachment 65615 [details] [review] [SIGNED-OFF] Bug 19053: Keep auto_renew flag if a confirmation is needed If an item is checked out with the auto renewal flag and a confirmation is needed (holds exist, past due date, etc.) the auto renewal flag will get lost. Test plan: - Check an item out and specify a past due date - Confirm the checkout on the confirmation screen => Without this patch the checkout is not marked as auto renewal => With this patch applied the auto renewal flag will be set to the checkout Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 65886 [details] [review] Bug 19053: Keep auto_renew flag if a confirmation is needed If an item is checked out with the auto renewal flag and a confirmation is needed (holds exist, past due date, etc.) the auto renewal flag will get lost. Test plan: - Check an item out and specify a past due date - Confirm the checkout on the confirmation screen => Without this patch the checkout is not marked as auto renewal => With this patch applied the auto renewal flag will be set to the checkout Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.04 This patch has been pushed to 16.11.x and will be in 16.11.12. Pushed to 16.05.x, for 16.05.17 release |