Bug 19055

Summary: GetReservesToBranch is not used
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Julian Maurice <julian.maurice>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, julian.maurice, katrin.fischer, veron
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19025    
Bug Blocks: 17728, 19056    
Attachments: Bug 19055: Remove C4::Reserves::GetReservesToBranch
Bug 19055: Remove C4::Reserves::GetReservesToBranch
Bug 19055: Remove C4::Reserves::GetReservesToBranch
Bug 19055: Remove C4::Reserves::GetReservesToBranch

Description Jonathan Druart 2017-08-07 20:24:19 UTC
Let's remove it
Comment 1 Jonathan Druart 2017-08-07 20:44:16 UTC
Created attachment 65600 [details] [review]
Bug 19055: Remove C4::Reserves::GetReservesToBranch

This subroutine is no longer in used and can be removed

Test plan:
  git grep GetReservesToBranch
must not return any results
Comment 2 Jonathan Druart 2017-08-07 20:50:02 UTC
Created attachment 65603 [details] [review]
Bug 19055: Remove C4::Reserves::GetReservesToBranch

This subroutine is no longer in used and can be removed

Test plan:
  git grep GetReservesToBranch
must not return any results
Comment 3 Marc Véron 2017-08-08 08:20:26 UTC
Created attachment 65616 [details] [review]
Bug 19055: Remove C4::Reserves::GetReservesToBranch

This subroutine is no longer in used and can be removed

Test plan:
  git grep GetReservesToBranch
must not return any results

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Julian Maurice 2017-09-01 09:47:55 UTC
Created attachment 66694 [details] [review]
Bug 19055: Remove C4::Reserves::GetReservesToBranch

This subroutine is no longer in used and can be removed

Test plan:
  git grep GetReservesToBranch
must not return any results

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Jonathan Druart 2017-09-01 16:07:45 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 6 Fridolin Somers 2017-10-03 08:20:25 UTC
Pushed to 17.05.x, will be in 17.05.05.

No call in this version neither.
Comment 7 Katrin Fischer 2017-10-05 21:28:19 UTC
This patch has been pushed to 16.11.x and will be in 16.11.13.