Summary: | Move C4::Reserves::GetReserveCount to the Koha namespace | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice, veron |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 19055 | ||
Bug Blocks: | 17728, 19057 | ||
Attachments: |
Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count
Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count |
Description
Jonathan Druart
2017-08-07 20:42:12 UTC
Created attachment 65604 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Created attachment 65617 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 66696 [details] [review] Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.11, thanks to everybody involved! Isn't this enhancement ? (In reply to Fridolin SOMERS from comment #5) > Isn't this enhancement ? Changed to enhancement. |