Summary: | OPAC purchase suggestion doesn't allow users to enter quantity of items | ||
---|---|---|---|
Product: | Koha | Reporter: | Jon Knight <J.P.Knight> |
Component: | OPAC | Assignee: | Jon Knight <J.P.Knight> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, niamh.walker-headon, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
One line addition to opac-suggestions.tt to allow quantities to be entered
Add quantity field to the opac suggestions form. Add quantity field to the opac suggestions form. Add quantity field to the opac suggestions form (with correct username and email) [SIGNED OFF] Add quantity field to the opac suggestions form (with correct username and email) Add quantity field to the opac suggestions form (with correct username and email) |
Description
Jon Knight
2017-08-09 16:11:49 UTC
Hi Jon, there is some information missing from your patch so that it doesn't apply cleanly with git commands. It's missing the "header" on top, that includes your authorship etc. How did you create the patch? You can create formatted patch files with "git format-patch" Or you could use git bz (https://wiki.koha-community.org/wiki/Git_bz_configuration). If you are using a kohadevbox this will already be preinstalled, but requires some settings in your configuration file to work right. Please let us know if we can help! I created the patch using "git diff". I'll create a formatted patch next week (I'm not at the machine that has the kohadevbox VM on it at the moment). Created attachment 66281 [details] [review] Add quantity field to the opac suggestions form. New version of the patch uploaded, hopefully this time in the correct format. Hi Jon, patch def looks better! One more small but important thing. In the second line of the patch it reads: From: Your Full Name <your_email> That means you haven't set up your git completely yet. The name and address there will be visible in git and also will make your name show up in the release notes. I think you will just need to run those 2 commands with your correct information, before rerunning the format-patch command again: git config --global user.name "Your NAME" git config --global user.email "your@mail.com" Ah thanks - those lines weren't in the git bz config set up on https://wiki.koha-community.org/wiki/Git_bz_configuration#Configure_git-bz that I followed to set up the kohadevbox git bz set up. Created attachment 66339 [details] [review] Add quantity field to the opac suggestions form. Created attachment 66340 [details] [review] Add quantity field to the opac suggestions form (with correct username and email) I think the git bz instructions might have originally been written with developers switching to it in mind - I'll try to take a look. New patch looks perfect, will try to test and thx for your patience so far! Created attachment 66371 [details] [review] [SIGNED OFF] Add quantity field to the opac suggestions form (with correct username and email) https://bugs.koha-community.org/show_bug.cgi?id=19068 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 66755 [details] [review] Add quantity field to the opac suggestions form (with correct username and email) https://bugs.koha-community.org/show_bug.cgi?id=19068 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Looks good, includes id so easy to hide if unwanted Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.06. This won't get ported back to 16.11.x as it is an enhancement. |