| Summary: | REST API: Toggle suspend for /api/v1/holds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lari Taskula <lari.taskula> | 
| Component: | REST API | Assignee: | Lari Taskula <lari.taskula> | 
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | benjamin.rokseth, jonathan.druart, josef.moravec | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 18137 | ||
| Bug Blocks: | |||
| Attachments: | Bug 19072: Toggle suspend for /api/v1/holds Bug 19072: Toggle suspend for /api/v1/holds Bug 19072: Toggle suspend for /api/v1/holds Bug 19072: Toggle suspend for /api/v1/holds Bug 19072: Toggle suspend for /api/v1/holds | ||
| 
        
          Description
        
        
          Lari Taskula
        
        
        
        
          2017-08-10 09:30:56 UTC
        
       Created attachment 65792 [details] [review] Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed Created attachment 65793 [details] [review] Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed Created attachment 65794 [details] [review] Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed Created attachment 65795 [details] [review] Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed Created attachment 65796 [details] [review] Bug 19072: Toggle suspend for /api/v1/holds This patch adds ability to toggle suspend for a hold. To test: 1. prove t/db_dependent/api/v1/holds.t 2. Send a PUT request to suspended hold with suspend_until parameter as null 3. Observe that hold is now resumed The use of C4::Reserves::ToggleSuspend is a bit counter-intuitive here. If you send a PUT to /api/v1/holds/x with '{"suspend":false}' it would suspend hold if it was not already suspended.
I would rather respect the body request and suspend according to that, or you would have unpredictable results. |