Summary: | 'Show all details' checkbox on basket summary page is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12333 | ||
Bug Blocks: | |||
Attachments: |
Bug 19083: Fix 'show all details' link on closed basket detail
Bug 19083: Fix 'show all details' link on closed basket detail Bug 19083: Fix 'show all details' link on closed basket detail Bug 19083: Fix 'show all details' link on closed basket detail |
Description
Katrin Fischer
2017-08-10 23:50:07 UTC
Ah, noticed something: It's not working when the basket is closed and in a basket group. So this should be added to the test plan. Otherwise it appears to work still. Created attachment 67874 [details] [review] Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Created attachment 67958 [details] [review] Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch tested with a sandbox, by Jon Knight <J.P.Knight@lboro.ac.uk> Created attachment 67965 [details] [review] Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Created attachment 68056 [details] [review] Bug 19083: Fix 'show all details' link on closed basket detail 'Show all details' add columns on the basket summary page. This link is broken if the basket is closed. Indeed there is a JS error raised by $('#toolbar').fixFloat(); The toolbar is not displayed if the basket is closed. This is caused by bug 12333, which added the floating toolbar. Test plan: Create 2 baskets with orders Close 1 basket Click on the 'show all details' links and confirm it works as expected Also confirm that the toolbar works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! |