Summary: | XSS Flaws in memberentry.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
Component: | Architecture, internals, and plumbing | Assignee: | Amit Gupta <amitddng135> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | amit.gupta, amitddng135, chris, fridolin.somers, jonathan.druart, m.de.rooy, mtj, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 14568 | ||
Attachments: |
Bug 19100 - XSS Flaws in memberentry.pl
Bug 19100 - XSS Flaws in memberentry.pl [SIGNED-OFF] Bug 19100 - XSS Flaws in memberentry.pl Bug 19100 - XSS Flaws in memberentry.pl |
Description
Amit Gupta
2017-08-14 17:32:31 UTC
Created attachment 65971 [details] [review] Bug 19100 - XSS Flaws in memberentry.pl 1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid. 5. Notice it is no longer executed. Created attachment 66033 [details] [review] Bug 19100 - XSS Flaws in memberentry.pl 1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid. 5. Notice it is no longer executed. ************************** escaping from the template. Created attachment 66035 [details] [review] [SIGNED-OFF] Bug 19100 - XSS Flaws in memberentry.pl 1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid. 5. Notice it is no longer executed. NOTE: I had to test in Microsoft Edge, because Chrome was blocking XSS for me. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 66065 [details] [review] Bug 19100 - XSS Flaws in memberentry.pl 1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> xx - is a guarantorid. 5. Notice it is no longer executed. NOTE: I had to test in Microsoft Edge, because Chrome was blocking XSS for me. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, is in 17.05.03 Pushed to 16.05.x, for 16.05.16 release - thanks Amit :0) |