| Summary: | XSS Stored in holidays.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
| Component: | Architecture, internals, and plumbing | Assignee: | Amit Gupta <amitddng135> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | amit.gupta, amitddng135, chris, fridolin.somers, jonathan.druart, m.de.rooy, mtj, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19124 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14568 | ||
| Attachments: |
Bug 19105 - XSS Stored in holidays.pl
[SIGNED OFF] Bug 19105 - XSS Stored in holidays.pl Bug 19105 - XSS Stored in holidays.pl |
||
|
Description
Amit Gupta
2017-08-15 03:51:43 UTC
Created attachment 65993 [details] [review] Bug 19105 - XSS Stored in holidays.pl To Test 1. Hit the page /cgi-bin/koha/tools/holidays.pl 2. Select the date 3. Add a text in the field Title and Description that contains js 4. Save the page. 5. Notice js is execute 6. Apply patch and reload, the js is escaped Fixed for all holidays Interesting finding here: I still had the branch named "<script>alert("Test")</script>" and it executes twice on this page. Opened a separate bug: bug 19124
Created attachment 66052 [details] [review] [SIGNED OFF] Bug 19105 - XSS Stored in holidays.pl To Test 1. Hit the page /cgi-bin/koha/tools/holidays.pl 2. Select the date 3. Add a text in the field Title and Description that contains js 4. Save the page. 5. Notice js is execute 6. Apply patch and reload, the js is escaped Fixed for all holidays Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 66078 [details] [review] Bug 19105 - XSS Stored in holidays.pl To Test 1. Hit the page /cgi-bin/koha/tools/holidays.pl 2. Select the date 3. Add a text in the field Title and Description that contains js 4. Save the page. 5. Notice js is execute 6. Apply patch and reload, the js is escaped Fixed for all holidays Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, is in 17.05.03 This patch has been pushed to 16.11.x and is in 16.11.11. Pushed to 16.05.x, for 16.05.16 release - thanks Amit :0) |