Bug 19110

Summary:	XSS Stored in branches.pl
Product:	Koha	Reporter:	Amit Gupta <amitddng135>
Component:	Architecture, internals, and plumbing	Assignee:	Amit Gupta <amitddng135>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	major
Priority:	P5 - low	CC:	amit.gupta, amitddng135, chris, fridolin.somers, jonathan.druart, m.de.rooy, mtj, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:
Bug Blocks:	14568
Attachments:	Bug 19110 - XSS Stored in branches.pl [SIGNED OFF] Bug 19110 - XSS Stored in branches.pl Bug 19110 - XSS Stored in branches.pl

Description Amit Gupta 2017-08-15 09:23:32 UTC

1. JS executing while deleting the branch
/cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=[branchcode]
2. JS executing while creating the new group.
/cgi-bin/koha/admin/branches.pl?op=add_form_category

Comment 1 Amit Gupta 2017-08-15 09:36:06 UTC

Created attachment 66003 [details] [review]
Bug 19110 - XSS Stored in branches.pl

To Test
1. Hit the page /cgi-bin/koha/admin/branches.pl?op=add_form_category
2. Add a text in the field Name and description that contains js.
3. Save the page.
4. Notice js is execute
5. Apply patch and reload, the js is escaped

Fixed for js escaped execute for both pages

1. /cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=xx
   xx is branchcode
2. /cgi-bin/koha/admin/branches.pl?op=add_form with Group(s):

Comment 2 Katrin Fischer 2017-08-16 09:16:10 UTC

Created attachment 66051 [details] [review]
[SIGNED OFF] Bug 19110 - XSS Stored in branches.pl

To Test
1. Hit the page /cgi-bin/koha/admin/branches.pl?op=add_form_category
2. Add a text in the field Name and description that contains js.
3. Save the page.
4. Notice js is execute
5. Apply patch and reload, the js is escaped

Fixed for js escaped execute for both pages

1. /cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=xx
   xx is branchcode
2. /cgi-bin/koha/admin/branches.pl?op=add_form with Group(s):

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Marcel de Rooy 2017-08-16 11:39:51 UTC

Created attachment 66077 [details] [review]
Bug 19110 - XSS Stored in branches.pl

To Test
1. Hit the page /cgi-bin/koha/admin/branches.pl?op=add_form_category
2. Add a text in the field Name and description that contains js.
3. Save the page.
4. Notice js is execute
5. Apply patch and reload, the js is escaped

Fixed for js escaped execute for both pages

1. /cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=xx
   xx is branchcode
2. /cgi-bin/koha/admin/branches.pl?op=add_form with Group(s):

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Jonathan Druart 2017-08-29 15:07:45 UTC

Pushed to master for 17.11, thanks to everybody involved!

Comment 5 Fridolin Somers 2017-09-05 12:43:22 UTC

Pushed to 17.05.x, is in 17.05.03

Comment 6 Katrin Fischer 2017-09-07 06:13:52 UTC

This patch has been pushed to 16.11.x and is in 16.11.11.

Comment 7 Mason James 2017-09-20 02:41:14 UTC

Pushed to 16.05.x, for 16.05.16 release - thanks Amit :0)