Summary: | IncludeSeeFromInSearches is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | barton, fridolin.somers, jens.weber, jonathan.druart, mik, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 18098 | ||
Bug Blocks: | |||
Attachments: |
Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour
k Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour |
Description
Katrin Fischer
2017-08-15 22:40:50 UTC
This feature is important as it makes authorities so much more useful. This functionality was definitively working in Koha 3.20.4. It is for sure broken in Koha 16.11.4 (this was a new installation, upgraded from 16.11.0) and Koha 17.05.1 (after the upgrade from Koha 3.20.4). Caused by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items Created attachment 67526 [details] [review] Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings Oops. Thank for taking care, Jonathan! Created attachment 67535 [details] [review] k Created attachment 67536 [details] [review] Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 67564 [details] [review] Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Yet another reason to get rid of all this functions from this script. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. Dependency is not in 16.11.x, this does not apply. Does this fix the combination of sysprefs documented in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715#c2 ? |