Summary: | Fix Members.t with IndependentBranches set | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19126: Fix Members.t with IndependentBranches set
[SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set Bug 19126: Fix Members.t with IndependentBranches set |
Description
Marcel de Rooy
2017-08-16 11:11:26 UTC
Created attachment 66064 [details] [review] Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 66259 [details] [review] [SIGNED-OFF] Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 66484 [details] [review] Bug 19126: Fix Members.t with IndependentBranches set If you enabled that pref, Members.t fails with: t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63. The first one is: t/db_dependent/Members.t .. 32/63 Failed test 'Staff patron not deleted from list' at t/db_dependent/Members.t line 304. Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the state of this preference. Trivially fixing it here by disabling the pref before the first call. Test plan: [1] Do not apply this patch yet. Enable IndependentBranches. [2] Run Members.t and observe that it fails. [3] Apply this patch. And run Members.t again. It should pass now. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |