Description
Tomás Cohen Arazi (tcohen)
2017-08-16 21:46:29 UTC
Created attachment 66348 [details] [review] Bug 19130: Remove ->search() overloading and adjust tests This patch removes the custom ->search() function. Tests are adjusted so the results from ->search() calls are not expected to return in the previously hardcoded order. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Bookseller.t => SUCCESS: Tests pass - Sign off :-D Created attachment 66349 [details] [review] Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t This followup patch adds a proper file in which add tests for Koha::Acquisition::Bookseller(s) methods. All current methods are covered. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t => SUCCESS: Test pass! - Sign off :-D Created attachment 66350 [details] [review] Bug 19130: (followup) Add POD This patch adds POD to the following files: - Koha/Acquisition/Bookseller.pm - Koha/Acquisition/Booksellers.pm Created attachment 66352 [details] [review] Bug 19130: (followup) Controller scripts should preserve behaviour This patch is a followup to making Koha::Acquisition::Booksellers->search work as any other Koha::Objects (DBIC) query instead of having a different behaviour hardcoded. To achieve it, this patch makes the controller scripts add wildcard/truncation chars as prefix and sufix for searches, and make the default sorting for results be by 'name', ascending. To test: - Just verify the behaviour remains unchanged by this patchset on the controller scripts (re. searching). Created attachment 66365 [details] [review] Bug 19130: Remove ->search() overloading and adjust tests This patch removes the custom ->search() function. Tests are adjusted so the results from ->search() calls are not expected to return in the previously hardcoded order. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Bookseller.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66366 [details] [review] Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t This followup patch adds a proper file in which add tests for Koha::Acquisition::Bookseller(s) methods. All current methods are covered. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t => SUCCESS: Test pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66367 [details] [review] Bug 19130: (followup) Add POD This patch adds POD to the following files: - Koha/Acquisition/Bookseller.pm - Koha/Acquisition/Booksellers.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66368 [details] [review] Bug 19130: (followup) Controller scripts should preserve behaviour This patch is a followup to making Koha::Acquisition::Booksellers->search work as any other Koha::Objects (DBIC) query instead of having a different behaviour hardcoded. To achieve it, this patch makes the controller scripts add wildcard/truncation chars as prefix and sufix for searches, and make the default sorting for results be by 'name', ascending. To test: - Just verify the behaviour remains unchanged by this patchset on the controller scripts (re. searching). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 66480 [details] [review] Bug 19130: Remove ->search() overloading and adjust tests This patch removes the custom ->search() function. Tests are adjusted so the results from ->search() calls are not expected to return in the previously hardcoded order. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Bookseller.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 66481 [details] [review] Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t This followup patch adds a proper file in which add tests for Koha::Acquisition::Bookseller(s) methods. All current methods are covered. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t => SUCCESS: Test pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 66482 [details] [review] Bug 19130: (followup) Add POD This patch adds POD to the following files: - Koha/Acquisition/Bookseller.pm - Koha/Acquisition/Booksellers.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 66483 [details] [review] Bug 19130: (followup) Controller scripts should preserve behaviour This patch is a followup to making Koha::Acquisition::Booksellers->search work as any other Koha::Objects (DBIC) query instead of having a different behaviour hardcoded. To achieve it, this patch makes the controller scripts add wildcard/truncation chars as prefix and sufix for searches, and make the default sorting for results be by 'name', ascending. To test: - Just verify the behaviour remains unchanged by this patchset on the controller scripts (re. searching). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. Dependent bug 13726 is not in 16.11.x. |