Summary: | Noisy warns when creating or editing a basket | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Acquisitions | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dominic.pichette, fridolin.somers, jonathan.druart, katrin.fischer, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 19195: Preventing noisy warns when creating or editing a basket
Bug 19195: Preventing noisy warns when creating or editing a basket Bug 19195: Do not explicitely force scalar context when unecessary |
Description
Aleisha Amohia
2017-08-29 05:02:07 UTC
Created attachment 66574 [details] [review] Bug 19195: Preventing noisy warns when creating or editing a basket To test: 1) Open the koha intranet error log 2) Go to Acquisitions -> Find or create a vendor 3) Create a new basket, filling all fields 4) Notice warns in error log 5) Edit this basket 6) Notice warns in error log 7) Apply patch 8) Create another basket, confirm warns do not show 9) Edit this basket, confirm warns do not show Sponsored-by: Catalyst IT Created attachment 67166 [details] [review] Bug 19195: Preventing noisy warns when creating or editing a basket To test: 1) Open the koha intranet error log 2) Go to Acquisitions -> Find or create a vendor 3) Create a new basket, filling all fields 4) Notice warns in error log 5) Edit this basket 6) Notice warns in error log 7) Apply patch 8) Create another basket, confirm warns do not show 9) Edit this basket, confirm warns do not show Sponsored-by: Catalyst IT signed-off by : Dominic Pichette Created attachment 67217 [details] [review] Bug 19195: Do not explicitely force scalar context when unecessary These ones are already called in scalar context Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.06. These patches have been pushed to 16.11.x and will be in 16.11.14. Pushed to 16.05.x, for 16.05.19 release |