Bug 19235

Summary: Password visible in OPAC self registration
Product: Koha Reporter: Apurba Jyoti Majumder <apurbajyoti>
Component: OPACAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: apurbajyoti, fridolin.somers, katrin.fischer, mtompset
Version: 16.11   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: snapshop of the bug
Bug 19235: Password entry visible in OPAC Self-registration
Bug 19235: Password entry visible in OPAC Self-registration
Bug 19235: Password entry visible in OPAC Self-registration

Description Apurba Jyoti Majumder 2017-09-01 16:03:50 UTC
Created attachment 66759 [details]
snapshop of the bug

1. OPAC Self Registration
2. Type password
3. Password characters visible
Comment 1 Mark Tompsett 2017-09-01 17:22:19 UTC
Created attachment 66768 [details] [review]
Bug 19235: Password entry visible in OPAC Self-registration

The HTML code was "text" instead of "password".

TEST PLAN
----------
1) 'Allow' PatronSelfRegistration system preference
2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT)
3) Open OPAC
4) Click 'Register here' on the right.  (/cgi-bin/koha/opac-memberentry.pl)
5) Scroll to bottom
6) enter some passwords
   -- visible
7) apply this patch
8) refresh page
9) repeat 5-6 as needed
   -- passwords should not be visible while entering
10) run koha qa test tools
Comment 2 Lee Jamison 2017-09-01 19:52:33 UTC
Created attachment 66782 [details] [review]
Bug 19235: Password entry visible in OPAC Self-registration

The HTML code was "text" instead of "password".

TEST PLAN
----------
1) 'Allow' PatronSelfRegistration system preference
2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT)
3) Open OPAC
4) Click 'Register here' on the right.  (/cgi-bin/koha/opac-memberentry.pl)
5) Scroll to bottom
6) enter some passwords
   -- visible
7) apply this patch
8) refresh page
9) repeat 5-6 as needed
   -- passwords should not be visible while entering
10) run koha qa test tools

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Comment 3 Apurba Jyoti Majumder 2017-09-06 05:29:05 UTC
The steps has been followed and tested OK
Noe the password character are not visible.
Comment 4 Nick Clemens 2017-09-08 17:36:03 UTC
Created attachment 67008 [details] [review]
Bug 19235: Password entry visible in OPAC Self-registration

The HTML code was "text" instead of "password".

TEST PLAN
----------
1) 'Allow' PatronSelfRegistration system preference
2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT)
3) Open OPAC
4) Click 'Register here' on the right.  (/cgi-bin/koha/opac-memberentry.pl)
5) Scroll to bottom
6) enter some passwords
   -- visible
7) apply this patch
8) refresh page
9) repeat 5-6 as needed
   -- passwords should not be visible while entering
10) run koha qa test tools

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Jonathan Druart 2017-09-12 15:13:09 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 6 Fridolin Somers 2017-09-19 15:05:31 UTC
Pushed to 17.05.x, will be in 17.05.04.
Comment 7 Katrin Fischer 2017-09-19 21:21:52 UTC
This patch has been pushed to 16.11.x and will be in 16.11.12.