Bug 19268

Summary: Fix wrong TestBuilder parameter in few unit tests
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jonathan.druart
Version: master   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: Trivial patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 15339    
Attachments: Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

Description Marcel de Rooy 2017-09-07 09:51:49 UTC
Bug 15339 made these errors visible.
The values parameter should be value.
Comment 1 Marcel de Rooy 2017-09-07 09:58:26 UTC
Created attachment 66918 [details] [review]
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

The values parameter should be called value.
See bug 15339.

Test plan:
Run the adjusted tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2017-09-07 10:22:33 UTC
Jonathan: This could go along with 15339, but does not depend on it.
Funny that these tests passed with other values than expected..
Comment 3 Jonathan Druart 2017-09-07 16:52:49 UTC
Created attachment 66949 [details] [review]
Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t

The values parameter should be called value.
See bug 15339.

Test plan:
Run the adjusted tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2017-09-07 18:09:02 UTC
Pushed to master for 17.11, thanks to everybody involved!
Comment 5 Fridolin SOMERS 2017-10-10 09:52:07 UTC
Depends on Bug 15339 that is not in 17.05.x