Summary: | Ordered/Spent lists should display vendor name, not vendor code | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 19271: Show vendor name and format prices on ordered/spent lists
Bug 19271: Show vendor name and format prices on ordered/spent lists Bug 19271: Show vendor name on ordered/spent lists Bug 19271: Format prices on ordered/spent lists Bug 19271: Show vendor name on ordered/spent lists |
Description
Katrin Fischer
2017-09-07 10:58:35 UTC
Created attachment 77705 [details] [review] Bug 19271: Show vendor name and format prices on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Format prices according to CurrencyFormat system preference - Show the vendor's name instead of the internal number To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - All price information is shown according to CurrencyFormat - Vendor name shows I get conflicts when trying to apply the patch koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt Created attachment 78979 [details] [review] Bug 19271: Show vendor name and format prices on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Format prices according to CurrencyFormat system preference - Show the vendor's name instead of the internal number To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - All price information is shown according to CurrencyFormat - Vendor name shows Everything works fine now. The names of the vendors appear! :) I would not format the prices in the same patch/bug report, I am expecting regressions here: sum of round numbers (sprintf %.2f) vs round of sum (if it makes sense...) (In reply to Jonathan Druart from comment #5) > I would not format the prices in the same patch/bug report, I am expecting > regressions here: sum of round numbers (sprintf %.2f) vs round of sum (if it > makes sense...) Sorry, I don't understand. Can you explain? It seems to be the same change as in other places? use Modern::Perl; my $x = 12.344; my $y = 67.213; say sprintf("%.2f", $x)+sprintf("%.2f", $y); say sprintf("%.2f", $x+$y);' 79.55 79.56 Man that's upsetting, but I have to agree with Jonathan here.. the totals shouldn't really be calculated in this script in my opinion. But because they are, we can't make this change here. Could we perhaps split into two bugs please Katrin? Marking as Failed QA as now two of us agree that this change could have negative effects on calculations. What about keeping the format statements in the .pl file and still use the Price filter? Created attachment 79482 [details] [review] Bug 19271: Show vendor name on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Show the vendor's name instead of the internal number To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - Vendor name shows Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 79483 [details] [review] Bug 19271: Format prices on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Format prices according to CurrencyFormat system preference To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - All price information is shown according to CurrencyFormat Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Right.. I've split the patch in two.. left the accreditation with Katrin as the original author and signed off the first patch.. I'll now create a second bug and move the second patch over there. Second patch moved to bug 21427 unblocking this bug. Setting to Signed off Created attachment 79613 [details] [review] Bug 19271: Show vendor name on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Show the vendor's name instead of the internal number To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - Vendor name shows Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 |