| Summary: | clubs table broken at the opac if public enrollment is not allowed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Patrons | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | alexbuckley, gmcharlt, kyle.m.hall, kyle, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12461 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 19275 - clubs table broken at the opac if public enrollment is not allowed
Bug 19275 - clubs table broken at the opac if public enrollment is not allowed Bug 19275 - clubs table broken at the opac if public enrollment is not allowed |
||
|
Description
Jonathan Druart
2017-09-07 17:30:55 UTC
To recreate: Create a template club and disable public enrollment Create a club and add it a patron login at the opac with this patron => the table is broken at the opac, td are missing Created attachment 66998 [details] [review] Bug 19275 - clubs table broken at the opac if public enrollment is not allowed Test Plan: 1. Create a template club and disable public enrollment 2. Create a club and add it a patron 3. login at the opac with this patron 4. Note the borked clubs table 5. Apply this patch 6. Refresh the page 7. Table is fixed! Hi Kyle Sorry but running the QA test tool the clubs-tab.tt template fails (see below output). If you could please fix this up I will happily re-test and signoff as the patch worked as you described in your test plan: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/KohaDates.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206. I do not get this error. Created attachment 67962 [details] [review] Bug 19275 - clubs table broken at the opac if public enrollment is not allowed Test Plan: 1. Create a template club and disable public enrollment 2. Create a club and add it a patron 3. login at the opac with this patron 4. Note the borked clubs table 5. Apply this patch 6. Refresh the page 7. Table is fixed! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 68058 [details] [review] Bug 19275 - clubs table broken at the opac if public enrollment is not allowed Test Plan: 1. Create a template club and disable public enrollment 2. Create a club and add it a patron 3. login at the opac with this patron 4. Note the borked clubs table 5. Apply this patch 6. Refresh the page 7. Table is fixed! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! |