Summary: | Tax is being subtracted from orders when vendor price does not include gst and ordering from a file | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle.m.hall, m.de.rooy, matthias.meusburger |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15503 | ||
Bug Blocks: | |||
Attachments: |
Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices
Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices Bug 19296: (QA Follow-up) Correct comment in populate_orders |
Description
Nick Clemens (kidclamp)
2017-09-12 16:16:54 UTC
Created attachment 67110 [details] [review] Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices To test: 1 - Create an order file that includes prices and items (MarcFieldsToOrder) 2 - Stage the file 3 - Set vendor to 'prices exclude tax' 4 - Open a basket and add from the file 5 - View the items in the basket 6 - Prices are reduced by the tax rate and tax is calculated to return prices to the value in the file 7 - Apply patch 8 - Repeat steps 1-6 9 - Prices should now calculate correctly 10 - Repeat with 'MarcItemFieldsToOrder' Tested both variations: list price includes GST and list price doesn't include GST. Verified bug and made sure that price calculations for ordering from staged and ordering from new (empty) record now match and make sense. Created attachment 67822 [details] [review] Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices To test: 1 - Create an order file that includes prices and items (MarcFieldsToOrder) 2 - Stage the file 3 - Set vendor to 'prices exclude tax' 4 - Open a basket and add from the file 5 - View the items in the basket 6 - Prices are reduced by the tax rate and tax is calculated to return prices to the value in the file 7 - Apply patch 8 - Repeat steps 1-6 9 - Prices should now calculate correctly 10 - Repeat with 'MarcItemFieldsToOrder' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> QA: Looking here now Created attachment 68045 [details] [review] Bug 19296 - Allow all tax processing to happen in C4::Acquisition::populate_order_with_prices To test: 1 - Create an order file that includes prices and items (MarcFieldsToOrder) 2 - Stage the file 3 - Set vendor to 'prices exclude tax' 4 - Open a basket and add from the file 5 - View the items in the basket 6 - Prices are reduced by the tax rate and tax is calculated to return prices to the value in the file 7 - Apply patch 8 - Repeat steps 1-6 9 - Prices should now calculate correctly 10 - Repeat with 'MarcItemFieldsToOrder' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68046 [details] [review] Bug 19296: (QA Follow-up) Correct comment in populate_orders Just replacing a wrong - by a correct + sign in the comment. The code itself is fine. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> listprice is going to be different as well, is it expected? (In reply to Jonathan Druart from comment #7) > listprice is going to be different as well, is it expected? I think this is correct - if list price includes GST then it should already have it, if it doesn't it doesn't need it. Looking harder I am not sure why list price isn't just passed through the form but not adding that here. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.06. Dependent bug is not in 16.11.x, skipping. |