Bug 19303

Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: josef.moravec, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16846, 19304    
Attachments: Bug 19303 - Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address

Description Jonathan Druart 2017-09-12 21:40:57 UTC
This new Koha::Patron->first_valid_email_address already exists, it should be called directly.
Comment 1 Jonathan Druart 2017-09-13 19:42:48 UTC
Created attachment 67125 [details] [review]
Bug 19303 - Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address

This new Koha::Patron->first_valid_email_address already exists, it
should be called directly

Test plan:
With a logged in user who have an email address defined, send a basket.
The email should be marked sent by this email address
Comment 2 Jonathan Druart 2017-09-14 14:19:17 UTC
Created attachment 67137 [details] [review]
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address

This new Koha::Patron->first_valid_email_address already exists, it
should be called directly

Test plan:
- With a logged in user who have an email address defined, send a basket.
The email should be marked sent by this email address

- On the "Holds awaiting pickup", the email address must be displayed as well
Comment 3 David Bourgault 2017-10-13 20:30:49 UTC
Created attachment 68107 [details] [review]
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address

This new Koha::Patron->first_valid_email_address already exists, it
should be called directly

Test plan:
- With a logged in user who have an email address defined, send a basket.
The email should be marked sent by this email address

- On the "Holds awaiting pickup", the email address must be displayed as well

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 4 Josef Moravec 2018-01-02 08:28:15 UTC
Created attachment 70221 [details] [review]
Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address

This new Koha::Patron->first_valid_email_address already exists, it
should be called directly

Test plan:
- With a logged in user who have an email address defined, send a basket.
The email should be marked sent by this email address

- On the "Holds awaiting pickup", the email address must be displayed as well

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Jonathan Druart 2018-01-02 15:12:56 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-01-16 12:21:52 UTC
Enhancement, skipping for 17.11.x.
Awesome work everybody!