Summary: | Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david.bourgault, josef.moravec, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 19303 | ||
Bug Blocks: | 16846 | ||
Attachments: |
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Bug 19304: (QA follow-up) Fix number of tests in Members.t |
Description
Jonathan Druart
2017-09-12 21:41:45 UTC
Created attachment 67126 [details] [review] Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress I can't apply the patch fatal: sha1 information is lacking or useless (C4/Members.pm). Apply correctly for me, you need to apply the patches from bug 19303 first. Created attachment 68111 [details] [review] Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Created attachment 70222 [details] [review] Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 70223 [details] [review] Bug 19304: (QA follow-up) Fix number of tests in Members.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Pushed to master for 18.05, thanks to everybody involved! Enhancement, skipping for 17.11.x. Awesome work everybody! |