Bug 19304

Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: david.bourgault, josef.moravec, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19303    
Bug Blocks: 16846    
Attachments: Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address
Bug 19304: (QA follow-up) Fix number of tests in Members.t

Description Jonathan Druart 2017-09-12 21:41:45 UTC

    
Comment 1 Jonathan Druart 2017-09-13 19:44:10 UTC
Created attachment 67126 [details] [review]
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address

This subroutine is quite trivial and can be replaced easily with a new
method of Koha::Patron

Test plan:
Overdue notices and shelf sharing must be send the to an email address,
according to the value of the pref AutoEmailPrimaryAddress
Comment 2 David Bourgault 2017-09-29 20:45:10 UTC
I can't apply the patch

fatal: sha1 information is lacking or useless (C4/Members.pm).
Comment 3 Jonathan Druart 2017-10-02 13:30:36 UTC
Apply correctly for me, you need to apply the patches from bug 19303 first.
Comment 4 David Bourgault 2017-10-13 20:46:54 UTC
Created attachment 68111 [details] [review]
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address

This subroutine is quite trivial and can be replaced easily with a new
method of Koha::Patron

Test plan:
Overdue notices and shelf sharing must be send the to an email address,
according to the value of the pref AutoEmailPrimaryAddress

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 5 Josef Moravec 2018-01-02 08:46:56 UTC
Created attachment 70222 [details] [review]
Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address

This subroutine is quite trivial and can be replaced easily with a new
method of Koha::Patron

Test plan:
Overdue notices and shelf sharing must be send the to an email address,
according to the value of the pref AutoEmailPrimaryAddress

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Josef Moravec 2018-01-02 08:46:59 UTC
Created attachment 70223 [details] [review]
Bug 19304: (QA follow-up) Fix number of tests in Members.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Jonathan Druart 2018-01-02 15:13:02 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 8 Nick Clemens 2018-01-16 12:22:07 UTC
Enhancement, skipping for 17.11.x.
Awesome work everybody!