Summary: | Move of checkouts - Remove leftover | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, kyle |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18966 | ||
Bug Blocks: | |||
Attachments: |
Bug 19317: (bug 18966 follow-up) Remove leftover
Signed off removal of redundant line Bug 19317: (bug 18966 follow-up) Remove leftover |
Description
Jonathan Druart
2017-09-14 13:57:02 UTC
Created attachment 67136 [details] [review] Bug 19317: (bug 18966 follow-up) Remove leftover Nothing important here, but this line should have been removed by bug 18966: 2177 # Update the fines 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); The issue_id is now the same when moved from issues to old_issues. We do not need to update the accountlines table. No test plan here, you need to understand previous changes to validate this patch. Created attachment 67139 [details] [review] Signed off removal of redundant line Signed off - not only is it now redundant if you profile checkins it can be a bit wasteful of resources Created attachment 67450 [details] [review] Bug 19317: (bug 18966 follow-up) Remove leftover Nothing important here, but this line should have been removed by bug 18966: 2177 # Update the fines 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); The issue_id is now the same when moved from issues to old_issues. We do not need to update the accountlines table. No test plan here, you need to understand previous changes to validate this patch. Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.06. The removed lines don't appear to exist in 16.11.x. Closing. |