Bug 19324

Summary: New Inventory workflow eliminates "mark item seen" and doesn't show data in table
Product: Koha Reporter: Jessie Zairo <jzairo>
Component: ToolsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P3 CC: costalc, jrobb, katrin.fischer, kelly, m.de.rooy, mathsabypro, nick, r.delahunty, sally.healey
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14399    
Bug Blocks:    

Description Jessie Zairo 2017-09-15 14:06:10 UTC
With recent updates to 16.11.09 and the master release, there seem to be 2 functionality changes. The first is the workflow for marking items seen in the inventory tool seems to disappear. The second is Koha is not bringing back results (No data available in table) when you don't compare to a list.

Steps to recreate comparing barcodes against a list of results in 16.11.09 and master
1) Upload a file of barcodes with same shelving location
2) Choose option compare barcodes to list of results
3) Filter by library, call number or shelving location 
4) Click submit
5) you will be presented with a 2 boxes letting you know the number of items modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes read: xxx
6) No option to mark the results "Mark seen and quit" or "Mark seen and continue" or  "Continue without marking"

Steps to recreate NOT comparing barcodes against a list of results in 16.11.09 and master
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
4) you will be presented with a 2 boxes letting you know the number of items modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes read: xxx
5) No data available in table 
6) Koha no longer brings back results of the other filtered locations

We believe this is where the functionality changes from bug 14399
Fix inventory.pl part two (following 12913)

Steps to recreate NOT comparing barcodes against a list of results (16.11.04 & 16.11.07)
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
5) you will be presented with a 2 boxes letting you know the number of items modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes read: xxx
6) There is an option to mark the results "Mark seen and quit" or "Mark seen and continue" or  "Continue without marking"

Steps to recreate NOT comparing barcodes against a list of results (16.11.04 & 16.11.07)
1) Upload a file of barcodes with same shelving location
2) Filter by library, call number or shelving location 
3) Click submit
5) you will be presented with a 2 boxes letting you know the number of items modified : datelastseen set to xx/xx/xxx and the Number of potential barcodes read: xxx
6) We do not get an option to mark the results "Mark seen and quit" or "Mark seen and continue" or  "Continue without marking"
7) This does have a list of results in the table
Comment 1 Katrin Fischer 2017-09-16 07:06:07 UTC
Hi Jessica, I think this might be related to bug 14399 - I don't have much time to test right now, but linking both and adding Marcel here.
Comment 2 Marcel de Rooy 2017-10-02 13:16:43 UTC
Jessie,
Thanks for your comments.
It could be clarifying to read the four commit messages on the patches of bug 14399. At least I hope so ;)
You say that the workflow for marking items has disappeared. The fourth patch tells:
===
Currently, the value of compareinv2barcd is used to determine if the
Seen column, the Select/Clear all buttons and the Mark seen buttons are
displayed. But if we scanned barcodes, we already marked items as seen.
So we should only display these buttons when we did not upload barcodes.
===
In other words: We do no longer mark when we already marked.

> The second is Koha is not bringing back results (No data available in table) when you don't compare to a list.
It only reports errors on the barcodes you passed. If you do not pass barcodes, you will get an inventory list. If I have two barcodes (one item not on shelf H), I will get one result for the two barcodes and the filter on callnumber H. That is the one on the wrong location. Commit message 2 and 3 tell you more.
Comment 3 Jessie Zairo 2018-01-08 14:16:42 UTC
Thanks Marcel. 

Here are 2 major changes that library staff have contacted us about. 

Items that get checked in - if you don't use the 'Do not check in items scanned during inventory' option, the items get checked in but there's no longer a way to identify that. Previously a yellow box would report check-ins so staff could follow-up and make sure the items were mistakenly checked in, or if fines need written off.

Lost statuses get removed - if an item has a lost status, the inventory tool removes it but no longer reports that the status was removed. It was handy knowing which items changed, as often items marked 'Missing' were misshelved and the list of scanned barcodes can help identify where they are on the shelf. It would be great if the resulting report would list removal of a lost status for each affected item.
Comment 4 Mathieu Saby 2024-04-16 13:03:45 UTC
Still an issue in 2024