Summary: | XSS vulnerability in opac-shelves | ||
---|---|---|---|
Product: | Koha | Reporter: | Tom HANSTRA <hanstra> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, m.de.rooy, mtj, mtompset, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19333: Fix XSS in opac-shelves
Bug 19333: Fix XSS in opac-shelves |
Description
Tom HANSTRA
2017-09-18 16:35:40 UTC
Created attachment 67192 [details] [review] Bug 19333: Fix XSS in opac-shelves category is send back to the template, it must be escaped Are 506 and 514 correct? What about line 685? 684 is escaped. 506 <input type="hidden" name="category" value="category" /> 514 <input type="hidden" name="category" value="category" /> Are wrong, they are not TT variables 685 <input type="hidden" name="category" value="[% s.category %]" /> Should be ok, come from the DB and is varchar(1) Marking this failed QA because of Jonathan's comment#3 (In reply to Katrin Fischer from comment #4) > Marking this failed QA because of Jonathan's comment#3 My comment was saying the patch is correct ;) Created attachment 67951 [details] [review] Bug 19333: Fix XSS in opac-shelves category is send back to the template, it must be escaped Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Moving to PQA in same run Pushed to master for 17.11, thanks to everybody involved! This patch has been pushed to 16.11.x and will be in 16.11.13. These patches have been pushed to 17.05.x and are in 17.05.05. Pushed to 16.05.x, for 16.05.18 release |