| Summary: | Move staff client cart JavaScript to the footer | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, nick, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 17858 | ||
| Attachments: |
Bug 19356: Move staff client cart JavaScript to the footer
[SIGNED-OFF] Bug 19356: Move staff client cart JavaScript to the footer Bug 19356: Move staff client cart JavaScript to the footer |
||
|
Description
Owen Leonard
2017-09-21 13:49:54 UTC
Created attachment 67278 [details] [review] Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. Created attachment 67386 [details] [review] [SIGNED-OFF] Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Why the conditional for footerjs? If we are setting it statically why not just always include the js in footer? If I understand the variable is to prvent doc-head-close / intranet-bottom.inc from adding more js Created attachment 68080 [details] [review] Bug 19356: Move staff client cart JavaScript to the footer This patch modifies the staff client cart template so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Correction for QA: Removed contditional around footer JS (from copy-paste) because it will always be true. Pushed to master for 17.11, thanks to everybody involved! |