Summary: | CAS login for staff interface always goes back to home | ||
---|---|---|---|
Product: | Koha | Reporter: | Gwendal JONCOUR <gwendal.joncour> |
Component: | Authentication | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dpavlin, jonathan.druart, m.de.rooy, matthias.meusburger |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13507 | ||
Bug Blocks: | |||
Attachments: |
Bug 19373: CAS logout - Redirect to the previous page (Intranet)
Bug 19373: Update tests Bug 19373: Update tests Bug 19373: CAS logout - Redirect to the previous page (Intranet) Bug 19373: Update tests Bug 19373: CAS logout - Redirect to the previous page (Intranet) |
Description
Gwendal JONCOUR
2017-09-27 14:13:49 UTC
I guess it is an oversight, this behaviour exists since bug 13507. Created attachment 67405 [details] [review] Bug 19373: CAS logout - Redirect to the previous page (Intranet) I have not tested this patch. Tested on our 16.11 preproduction version and it works pretty good. not ok 4 - Intranet URL should be returned when using intranet login (Bug 13507) # Failed test 'Intranet URL should be returned when using intranet login (Bug 13507)' # at t/db_dependent/Auth_with_cas.t line 62. # got: 'localhost:8080/cgi-bin/koha/opac-user.pl?bar=baz' # expected: 'localhost:8080?bar=baz' Created attachment 67963 [details] [review] Bug 19373: Update tests Matts, could you take a look at these changes? I'm ok with this patch, and I successfully tested it on my local instance with BibLibre's CAS Test server. I'm signing it off. Created attachment 68077 [details] [review] Bug 19373: Update tests Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 68078 [details] [review] Bug 19373: CAS logout - Redirect to the previous page (Intranet) Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Created attachment 68171 [details] [review] Bug 19373: Update tests Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68172 [details] [review] Bug 19373: CAS logout - Redirect to the previous page (Intranet) Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.11, thanks to everybody involved! |