Summary: | Remove $5 charge from sample item types | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Cataloging | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, nick, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19377 - Remove $5 charge from sample item types
Bug 19377 - Remove $5 charge from sample item types Bug 19377: Follow - remove charge for 'books' in all sample data Bug 19377 - Remove $5 charge from sample item types Bug 19377: Follow - remove charge for 'books' in all sample data Bug 19377 - Remove $5 charge from sample item types Bug 19377: Follow - remove charge for 'books' in all sample data Bug 19377: (follow-up) Remove charge for 'books' in ru-RU sample data |
Description
David Cook
2017-09-28 02:59:27 UTC
Created attachment 67422 [details] [review] Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Good idea. However, I think it should be fixed in all languages, not only in English, e.g.: ./installer/data/mysql/pl-PL/optional/sample_itemtypes.sql ./installer/data/mysql/es-ES/optional/sample_itemtypes.sql ./installer/data/mysql/de-DE/optional/sample_itemtypes.sql (there are more) Created attachment 67426 [details] [review] Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) Created attachment 67763 [details] [review] Bug 19377: Follow - remove charge for 'books' in all sample data I added a followup to cleanup books across all the files, I noticed though that some samples have charges for some itemtypes, and other have them for none. Maybe we should standardize all of them? Having books cleaned up all across makes sense for me right now. I seem to remember to have removed some of the charges from the German installer as they were so annoying - others might have done similar. Created attachment 68367 [details] [review] Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 68368 [details] [review] Bug 19377: Follow - remove charge for 'books' in all sample data Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 68717 [details] [review] Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 68718 [details] [review] Bug 19377: Follow - remove charge for 'books' in all sample data Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 68784 [details] [review] Bug 19377: (follow-up) Remove charge for 'books' in ru-RU sample data Pushed to master for 17.11, thanks to everybody involved! |