|
Description
Julian Maurice
2017-09-28 10:04:41 UTC
Created attachment 67427 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Created attachment 67577 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Comment on attachment 67577 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Review of attachment 67577 [details] [review]: ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +239,5 @@ > my $holding_library = Koha::Libraries->find( $item->{holdingbranch} ); > $item->{'homebranchname'} = $home_library ? $home_library->branchname : ''; > $item->{'holdingbranchname'} = $holding_library ? $holding_library->branchname : ''; > + > + my ($transferDate, $transferFrom, $transferTo) = GetTransfers($item->{itemnumber}); You should use Koha::Item->get_transfer instead Also needs rebase because of Bug 13990 (QA follow-up) Add unit test coverage Created attachment 86740 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 86741 [details] [review] Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Created attachment 86800 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86801 [details] [review] Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec@gmail.com> tests need a rebase Created attachment 87187 [details] [review] Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87188 [details] [review] Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Patches rebased on master Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |