Bug 19385

Summary: t/Calendar.t is failing randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, katrin.fischer, richardvincent752
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 25551    
Attachments: Bug 19385: Fix random t/Calendar.t failure - clear the cache before

Description Jonathan Druart 2017-09-28 17:49:01 UTC
The cache 'exception_holidays' may be populated when we run these tests, we need to clear it before the tests are run.
Comment 1 Jonathan Druart 2017-09-28 17:51:28 UTC
Created attachment 67431 [details] [review]
Bug 19385: Fix random t/Calendar.t failure - clear the cache before

The cache 'exception_holidays' may be populated when we run these tests,
we need to clear it before the tests are run.

Test plan:
  prove t/db_dependent/Circulation/CalcDateDue.t  t/Calendar.t

Without this patch, t/Calendar will fail with:
  #   Failed test 'Exception holiday is not a closed day test'
  #   at t/Calendar.t line 159.
  #          got: '1'
  #     expected: '0'
  # Looks like you failed 1 test of 38.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2017-09-28 18:21:17 UTC
Pushed to master for 17.11.
Comment 3 Fridolin Somers 2017-10-03 14:00:10 UTC
Pushed to 17.05.x, will be in 17.05.05.
Comment 4 Katrin Fischer 2017-10-06 06:16:30 UTC
This patch has been pushed to 16.11.x and will be in 16.11.13.