Bug 19399

Summary:	Show reports screen should not display query in textarea
Product:	Koha	Reporter:	Barton Chittenden <barton>
Component:	Reports	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Barton Chittenden 2017-10-02 15:14:13 UTC

The Guided reports "Show SQL" e.g.

https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Show%20SQL

Looks very similar to the "Edit SQL" screen.

https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Edit%20SQL

Because of the visual similarity, there is a strong temptation to edit the SQL on the Show SQL screen. This is an annoyance; it would be better UX to display the SQL in a <code> tag.

Comment 1 Owen Leonard 2020-01-14 12:48:31 UTC

I wonder if this is improved by the switch to CodeMirror for viewing and editing SQL?

Comment 2 Katrin Fischer 2020-01-14 20:16:33 UTC

(In reply to Owen Leonard from comment #1)
> I wonder if this is improved by the switch to CodeMirror for viewing and
> editing SQL?

I think it's still valid, if you go to:
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Show%20SQL

It does look like the edit screen and you can put your cursor into it, even if you cannot type. Not sure if there is a 'just display' mode for codemirror?

Comment 3 Katrin Fischer 2023-09-30 20:36:54 UTC

I feel like the modal with the edit button below is probably making this clear enough now.