Summary: | Again and again, Circulation.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, katrin.fischer |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 19009 | ||
Bug Blocks: | 25551, 19776, 20721 | ||
Attachments: |
Bug 19403: Add some default values when building patrons for test
Bug 19403: Prevent Circulation.t to fail randomly |
Description
Jonathan Druart
2017-10-03 17:11:49 UTC
Created attachment 67565 [details] [review] Bug 19403: Add some default values when building patrons for test To avoid some tests to fail randomly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 67566 [details] [review] Bug 19403: Prevent Circulation.t to fail randomly Due to the number of test cases handle by CanBookBeIssued, Circulation.t fails randomly. To prevent that it is better to set some values. For instance if the patron is a statistical patron (category_type=X), the subroutine will return a STATS flag. This patch also adds a subroutine to the test file to display the keys of $error, $question and $alert set by CanBookBeIssued. It will be easier to track other random failures. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.11. Pushed to 17.05.x, will be in 17.05.06. Depends on a bug that is not in 16.11.x (didn't apply). Please fix dependencies if you want this to be included. |