Bug 19411

Summary: opac-shelves.tt : the opaccredits block should be outside of the main <div>
Product: Koha Reporter: David Bourgault <david.bourgault>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: HTML structure of opac-shelves.tt as displayed by Chrome dev tools.
opac-shelves.tt in Chrome element inspector
Screenshot of correctly-placed OPAC credits on advanced search page
Screenshot of correctly-placed OPAC credits on lists page

Description David Bourgault 2017-10-04 19:59:42 UTC
Created attachment 67614 [details]
HTML structure of opac-shelves.tt as displayed by Chrome dev tools.

The opac-shelves.tt template seems to have mismatch tags, resulting in the opaccredits <div> to be placed inside the main <div>. This can break CSS customization.
Comment 1 David Bourgault 2017-10-16 12:35:02 UTC
Similar issue exists in opac-advsearch.tt.
Comment 2 Owen Leonard 2017-11-29 13:44:06 UTC
I don't see a different between opac-shelves.tt, opac-advsearch.tt, and opac-main.tt in the placement of opaccredits. Could you double-check? Do you have any custom HTML (opacheader, opacmain, etc.) which might be causing the HTML to be off?
Comment 3 David Bourgault 2017-11-29 14:14:56 UTC
Created attachment 69422 [details]
opac-shelves.tt in Chrome element inspector

It might have been my database causing the issue in opac-advsearch.tt, but after clearing all html/css/js from my database, on master branch I could still reproduce the issue for opac-shelves.tt

As you can see in the file attached, the comment for closing main is two levels deeper than it should.
Comment 4 Owen Leonard 2017-12-13 16:39:21 UTC
Created attachment 69780 [details]
Screenshot of correctly-placed OPAC credits on advanced search page
Comment 5 Owen Leonard 2017-12-13 16:39:45 UTC
Created attachment 69781 [details]
Screenshot of correctly-placed OPAC credits on lists page
Comment 6 Owen Leonard 2017-12-13 16:40:16 UTC
I still cannot reproduce this problem.