Bug 19441

Summary: Several tests are failing on 16.05.x
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: m.de.rooy, mtj, mtompset, nick, tomascohen
Version: 16.05   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 19441: Fix xt/sample_notices.t
Bug 19441: Fix AuthorisedValues.t
Bug 19441: Fix AutomaticItemModificationByAge.t
Bug 19441: Fix t/db_dependent/Biblio/Isbd.t
Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t
Bug 19441: Remove ES-related tests
Bug 19441: Fix xt/sample_notices.t
Bug 19441: Fix AuthorisedValues.t
Bug 19441: Fix AutomaticItemModificationByAge.t
Bug 19441: Fix t/db_dependent/Biblio/Isbd.t
Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t
Bug 19441: Remove ES-related tests

Description Jonathan Druart 2017-10-09 21:42:34 UTC
xt_sample_notices_t.No sample notice to add
 xt_sample_notices_t.No sample notice to delete
 t_db_dependent_XISBN_t.Gets correct biblionumber from a book with a similar isbn using XISBN
 t_db_dependent_Template_Plugin_AuthorisedValues_t
 t_db_dependent_Items_AutomaticItemModificationByAge_t
 t_db_dependent_Biblio_Isbd_t
 t_db_dependent_SIP_Message_t
 t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t
 t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t
 t_db_dependent_00_strict_t.Syntax check misc/search_tools/rebuild_elastic_search.pl
 t_db_dependent_Koha_Elasticsearch_Indexer_t
 t_db_dependent_Koha_Elasticsearch_Indexer_t
 t_db_dependent_Biblio_TransformKohaToMarc_t
Comment 1 Jonathan Druart 2017-10-09 21:49:33 UTC
Created attachment 67852 [details] [review]
Bug 19441: Fix xt/sample_notices.t

fr-CA is not up-to-date:
- RESERVESLIP have been renamed with HOLD_SLIP
- PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined
Comment 2 Jonathan Druart 2017-10-09 21:49:36 UTC
Created attachment 67853 [details] [review]
Bug 19441: Fix AuthorisedValues.t

Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x
Comment 3 Jonathan Druart 2017-10-09 21:49:39 UTC
Created attachment 67854 [details] [review]
Bug 19441: Fix AutomaticItemModificationByAge.t

Koha::Caches does not exist in 16.05.x
Comment 4 Jonathan Druart 2017-10-09 21:49:42 UTC
Created attachment 67855 [details] [review]
Bug 19441: Fix t/db_dependent/Biblio/Isbd.t
Comment 5 Jonathan Druart 2017-10-09 21:49:45 UTC
Created attachment 67856 [details] [review]
Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t

Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x
Comment 6 Jonathan Druart 2017-10-09 21:52:05 UTC
Mason, there are too much tests failing on 16.05.x, you really need to make sure the tests do not fail before you push stuffs.

These patches should take care of most of the failures.

After them, only ES-related tests will fail, I did not manage to find the cause of the problem (Nick maybe?)
Comment 7 Nick Clemens (kidclamp) 2017-10-10 11:56:20 UTC
I think it's an ES version conflict - Elasticsearch.pm is referencing settings of type 'string' and using an older syntax for facets (now 'aggregations')

Related to 17255, ES for 16.11 and before only works with version 1.x of ES

Skip the tests? or adjust tests to run with older ES?
Comment 8 Tomás Cohen Arazi 2017-10-11 13:40:58 UTC
(In reply to Nick Clemens from comment #7)
> I think it's an ES version conflict - Elasticsearch.pm is referencing
> settings of type 'string' and using an older syntax for facets (now
> 'aggregations')
> 
> Related to 17255, ES for 16.11 and before only works with version 1.x of ES
> 
> Skip the tests? or adjust tests to run with older ES?

Skip the tests. A soon-to-die release, with no real ES support, we could even remove those.
Comment 9 Jonathan Druart 2017-10-11 13:51:04 UTC
Created attachment 67957 [details] [review]
Bug 19441: Remove ES-related tests

16.05.x do not provided stable ES support, it will take us too much time
to keep these tests up-to-date.
Comment 10 Jonathan Druart 2017-10-11 13:52:23 UTC
(In reply to Tomás Cohen Arazi from comment #8)
> we could even remove those.

granted!
Comment 11 Mark Tompsett 2017-10-14 04:00:59 UTC
Created attachment 68126 [details] [review]
Bug 19441: Fix xt/sample_notices.t

fr-CA is not up-to-date:
- RESERVESLIP have been renamed with HOLD_SLIP
- PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 12 Mark Tompsett 2017-10-14 04:01:02 UTC
Created attachment 68127 [details] [review]
Bug 19441: Fix AuthorisedValues.t

Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 13 Mark Tompsett 2017-10-14 04:01:05 UTC
Created attachment 68128 [details] [review]
Bug 19441: Fix AutomaticItemModificationByAge.t

Koha::Caches does not exist in 16.05.x

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 14 Mark Tompsett 2017-10-14 04:01:08 UTC
Created attachment 68129 [details] [review]
Bug 19441: Fix t/db_dependent/Biblio/Isbd.t

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 15 Mark Tompsett 2017-10-14 04:01:11 UTC
Created attachment 68130 [details] [review]
Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t

Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 16 Mark Tompsett 2017-10-14 04:01:14 UTC
Created attachment 68131 [details] [review]
Bug 19441: Remove ES-related tests

16.05.x do not provided stable ES support, it will take us too much time
to keep these tests up-to-date.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 17 Mark Tompsett 2017-10-14 04:03:37 UTC
prove before patch failed as expected.
prove after patch succeeded.

delete from letter;
source /home/vagrant/kohaclone/installer/data/mysql/fr-CA/obligatoire/sample_notices.sql

sample notices still passed

koha qa test tools passed.
Comment 18 Mason James 2017-10-24 05:04:49 UTC
Pushed to 16.05.x, for 16.05.18 release

thanks Jonathan :0)
Comment 19 Marcel de Rooy 2017-10-24 12:05:25 UTC
No apparent need to keep this in the SO queue