Description
Jonathan Druart
2017-10-09 21:42:34 UTC
Created attachment 67852 [details] [review] Bug 19441: Fix xt/sample_notices.t fr-CA is not up-to-date: - RESERVESLIP have been renamed with HOLD_SLIP - PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined Created attachment 67853 [details] [review] Bug 19441: Fix AuthorisedValues.t Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x Created attachment 67854 [details] [review] Bug 19441: Fix AutomaticItemModificationByAge.t Koha::Caches does not exist in 16.05.x Created attachment 67855 [details] [review] Bug 19441: Fix t/db_dependent/Biblio/Isbd.t Created attachment 67856 [details] [review] Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x Mason, there are too much tests failing on 16.05.x, you really need to make sure the tests do not fail before you push stuffs. These patches should take care of most of the failures. After them, only ES-related tests will fail, I did not manage to find the cause of the problem (Nick maybe?) I think it's an ES version conflict - Elasticsearch.pm is referencing settings of type 'string' and using an older syntax for facets (now 'aggregations') Related to 17255, ES for 16.11 and before only works with version 1.x of ES Skip the tests? or adjust tests to run with older ES? (In reply to Nick Clemens from comment #7) > I think it's an ES version conflict - Elasticsearch.pm is referencing > settings of type 'string' and using an older syntax for facets (now > 'aggregations') > > Related to 17255, ES for 16.11 and before only works with version 1.x of ES > > Skip the tests? or adjust tests to run with older ES? Skip the tests. A soon-to-die release, with no real ES support, we could even remove those. Created attachment 67957 [details] [review] Bug 19441: Remove ES-related tests 16.05.x do not provided stable ES support, it will take us too much time to keep these tests up-to-date. (In reply to Tomás Cohen Arazi from comment #8) > we could even remove those. granted! Created attachment 68126 [details] [review] Bug 19441: Fix xt/sample_notices.t fr-CA is not up-to-date: - RESERVESLIP have been renamed with HOLD_SLIP - PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 68127 [details] [review] Bug 19441: Fix AuthorisedValues.t Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 68128 [details] [review] Bug 19441: Fix AutomaticItemModificationByAge.t Koha::Caches does not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 68129 [details] [review] Bug 19441: Fix t/db_dependent/Biblio/Isbd.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 68130 [details] [review] Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 68131 [details] [review] Bug 19441: Remove ES-related tests 16.05.x do not provided stable ES support, it will take us too much time to keep these tests up-to-date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> prove before patch failed as expected. prove after patch succeeded. delete from letter; source /home/vagrant/kohaclone/installer/data/mysql/fr-CA/obligatoire/sample_notices.sql sample notices still passed koha qa test tools passed. Pushed to 16.05.x, for 16.05.18 release thanks Jonathan :0) No apparent need to keep this in the SO queue |