| Summary: | Error while attempting to duplicate a patron | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
| Component: | Patrons | Assignee: | Alex Arnaud <alex.arnaud> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl)
More problems with patron entry form Bug 19443 - remove duplicate message when editing existing patron Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl) Bug 19443 - remove duplicate message when editing existing patron Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl) Bug 19443 - remove duplicate message when editing existing patron |
||
Created attachment 67923 [details] [review] Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl) The form provided on top of the page if Koha find a duplicate patron is not closed. This cause some trouble. Test plan: - Edit the syspref IntranetUserJS and type the following code: "$(document).ready(function() { $("#memberentry_library_management").insertBefore("#memberentry_identity"); });" - create a patron so that Koha will warn you about a duplicate one, - click on "Not a duplicate. Save as new record", - you should get error(s) about empty field(s). Note that now, the library management part's fields are empty or reset to default Created attachment 67927 [details]
More problems with patron entry form
There are more problems with the form, additional attributes display outside, see screenshot attached.
(In reply to Marc Véron from comment #2) > Created attachment 67927 [details] > More problems with patron entry form > > There are more problems with the form, additional attributes display > outside, see screenshot attached. Can not reproduce this issue. On which step? Is there custom js? (In reply to Alex Arnaud from comment #3) > (In reply to Marc Véron from comment #2) > > Created attachment 67927 [details] > > More problems with patron entry form > > > > There are more problems with the form, additional attributes display > > outside, see screenshot attached. > > Can not reproduce this issue. On which step? Is there custom js? - No custom JS - Screenshot is from Home > Patrons > New patron I mentioned it here because this bug is related to HTML in patron entry form that is not correct. I can't reproduce the problem Marc shows in the screenshot, but I have another problem: If I click the "Edit existing record" button the existing patron's record is displayed, but it still has the "Duplicate patron record?" warning at the top. Created attachment 67987 [details] [review] Bug 19443 - remove duplicate message when editing existing patron Created attachment 67990 [details] [review] Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl) The form provided on top of the page if Koha find a duplicate patron is not closed. This cause some trouble. Test plan: - Edit the syspref IntranetUserJS and type the following code: "$(document).ready(function() { $("#memberentry_library_management").insertBefore("#memberentry_identity"); });" - create a patron so that Koha will warn you about a duplicate one, - click on "Not a duplicate. Save as new record", - you should get error(s) about empty field(s). Note that now, the library management part's fields are empty or reset to default Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 67991 [details] [review] Bug 19443 - remove duplicate message when editing existing patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 68691 [details] [review] Bug 19443 - wrong HTML in patron creation page (members/memberentry.pl) The form provided on top of the page if Koha find a duplicate patron is not closed. This cause some trouble. Test plan: - Edit the syspref IntranetUserJS and type the following code: "$(document).ready(function() { $("#memberentry_library_management").insertBefore("#memberentry_identity"); });" - create a patron so that Koha will warn you about a duplicate one, - click on "Not a duplicate. Save as new record", - you should get error(s) about empty field(s). Note that now, the library management part's fields are empty or reset to default Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 68692 [details] [review] Bug 19443 - remove duplicate message when editing existing patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x for v17.05.09 |
HTML in the patron creating/editing form is not correct. If you create a patron and Koha detect a duplicate one, the new page loaded contains a new form at the top with a button inside: "Not a duplicate. Save as new record" This form is not closed (</form>) and in some situations this could be problematic. Try this test plan: - Edit the syspref IntranetUserJS and type the following code: "$(document).ready(function() { $("#memberentry_library_management").insertBefore("#memberentry_identity"); });" This code move the "Library management" part (cardnumber, Library, Category etc...) on the top of the page. - create a patron so that Koha will warn you about a duplicate one, - click on "Not a duplicate. Save as new record", - you should get error(s) about empty field(s). Note that now, the library management part's fields are empty or reset to default