Bug 19455

Summary: Circulation/SwitchOnSiteCheckouts.t is failing randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 25551, 19776    
Attachments: Bug 19455: Prevent SwitchOnSiteCheckouts.t to fail randomly

Description Jonathan Druart 2017-10-12 14:18:55 UTC
#   Failed test 'Do not renew on-site checkouts'
#   at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 103.
#          got: undef
#     expected: '1'

#   Failed test 'If SwitchOnSiteCheckouts, switch the on-site checkout'
#   at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 107.
#          got: undef
#     expected: '1'

#   Failed test 'Specific case 1 - Switch is allowed'
#   at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 131.
#          got: undef
#     expected: '1'

#   Failed test 'Not a specific case, $delta should not be incremented'
#   at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 146.
#          got: undef
#     expected: 'TOO_MANY_CHECKOUTS'

#   Failed test 'Specific case 2 - Switch is allowed'
#   at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 159.
#          got: undef
#     expected: '1'
# Looks like you failed 5 tests of 10.
[19:29:48] t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
Comment 1 Jonathan Druart 2017-10-12 14:21:24 UTC
Created attachment 68014 [details] [review]
Bug 19455: Prevent SwitchOnSiteCheckouts.t to fail randomly

If categorycode is 'X', the test will fail

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2017-10-12 14:22:22 UTC
Pushed to master for 17.11
Comment 3 Fridolin Somers 2018-02-02 09:39:23 UTC
Pushed to 17.05.x for v17.05.09