|
Description
Kyle M Hall (khall)
2017-10-18 16:39:58 UTC
Created attachment 75321 [details] [review] Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds > 6 - Note the column has a tooltip to indicate item vs. record holds
I think it would be very helpful if we could have a tooltip on the table cells too:
"0 item holds / 3 total holds"
Created attachment 75489 [details] [review] Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> That's interesting !
Works fine for me.
A detail about css hiding : I had to use #tools_batchMod-edit .holds_count { display: none; }
Created attachment 75516 [details] [review] Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Created attachment 75533 [details] [review] Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 75534 [details] [review] Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Just tested once more with follow-up, tooltip on each row is clear for me. 1. There are "Show/hide columns" links on top of the page, the new column is not taken into account. 2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold on this record"? Failing QA for 1. Created attachment 79429 [details] [review] Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 79430 [details] [review] Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebasing (In reply to Jonathan Druart from comment #9) > 1. There are "Show/hide columns" links on top of the page, the new column is > not taken into account. This was intentional, there are two other columns at the start that cannot be hidden, this seemed appropriate for the holds info. I will attempt a followup > 2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold > on this record"? Will offer a followup shortly. > Failing QA for 1. Created attachment 80170 [details] [review] Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 80171 [details] [review] Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 80705 [details] [review] Bug 19490: (follow-up) Improve tooltip message and some tidying Created attachment 80708 [details] [review] Bug 19490: (follow-up) Improve tooltip message and some tidying Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. From commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea Bug 19490: Add a 'Holds' column to the items batchmodification tool This following line: + $this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count; displays a DBIC warning: [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl Must be ->search({ itemnumber => $itemnumber })->count (In reply to Jonathan Druart from comment #19) > From > commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea > Bug 19490: Add a 'Holds' column to the items batchmodification tool > > This following line: > + $this_row{item_holds} = Koha::Holds->search( itemnumber => > $itemnumber )->count; > > displays a DBIC warning: > [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client > 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: > DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use > search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm > line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: > http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl > > Must be ->search({ itemnumber => $itemnumber })->count See bug 24051. |