Summary: | Add reservedate to Holds awaiting pickup | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Circulation | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, nick, simon.pouchol |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 19494: Add reservedate to Holds awaiting pickup
Bug 19494: Add reservedate to Holds awaiting pickup Bug 19494: Add reservedate to Holds awaiting pickup Bug 19494: (QA follow-up) Rename column and apply title-string Bug 19494: Add reservedate to Holds awaiting pickup Bug 19494: (QA follow-up) Rename column and apply title-string |
Description
Marcel de Rooy
2017-10-19 10:00:56 UTC
Created attachment 68291 [details] [review] Bug 19494: Add reservedate to Holds awaiting pickup Add reservedate to report. Change label "Available since" to "Waiting since". Note: The table (already) crosses the boundaries of its container. Also the vertical spacing for the first column (already) is not the same as the others. (Adding the second date only makes it more visible.) These minor design issues should be solved on another report. Test plan: [1] Go to Circulation, Holds awaiting pickup [2] Note the additional column for reservedate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68913 [details] [review] Bug 19494: Add reservedate to Holds awaiting pickup Add reservedate to report. Change label "Available since" to "Waiting since". Note: The table (already) crosses the boundaries of its container. Also the vertical spacing for the first column (already) is not the same as the others. (Adding the second date only makes it more visible.) These minor design issues should be solved on another report. Test plan: [1] Go to Circulation, Holds awaiting pickup [2] Note the additional column for reservedate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> (In reply to Simon Pouchol from comment #2) > Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Merci beaucoup, Simon. Created attachment 69738 [details] [review] Bug 19494: Add reservedate to Holds awaiting pickup Add reservedate to report. Change label "Available since" to "Waiting since". Note: The table (already) crosses the boundaries of its container. Also the vertical spacing for the first column (already) is not the same as the others. (Adding the second date only makes it more visible.) These minor design issues should be solved on another report. Test plan: [1] Go to Circulation, Holds awaiting pickup [2] Note the additional column for reservedate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Simple rebase Hi Marcel, I think <th>Reserve date</th> sould be "Hold date" or "Date hold placed" or similar, as we don't use reserve in the GUI. Also I think you need to add class="title-string" to ensure proper sorting of the date. Created attachment 70096 [details] [review] Bug 19494: (QA follow-up) Rename column and apply title-string As requested by Katrin, the column should not refer to Reserve but Hold. Sorting should be the same as Waiting since-column. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 70111 [details] [review] Bug 19494: Add reservedate to Holds awaiting pickup Add reservedate to report. Change label "Available since" to "Waiting since". Note: The table (already) crosses the boundaries of its container. Also the vertical spacing for the first column (already) is not the same as the others. (Adding the second date only makes it more visible.) These minor design issues should be solved on another report. Test plan: [1] Go to Circulation, Holds awaiting pickup [2] Note the additional column for reservedate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 70112 [details] [review] Bug 19494: (QA follow-up) Rename column and apply title-string As requested by Katrin, the column should not refer to Reserve but Hold. Sorting should be the same as Waiting since-column. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Enhancement, skipping for 17.11.x. Awesome work everybody! |