Description
Kelly McElligott
2017-10-19 20:28:54 UTC
Aleisha, can you take care of this one please? Created attachment 69404 [details] [review] Bug 19496: Fixing to_address for patron notes This patch ensures the patron note to_address is the branch email or the Koha Admin email, and the from_address is the patron's email. To test: 1) Ensure syspref 'allowcheckoutnotes' is turned on 2) Go to OPAC, leave a note on a checkout 3) Confirm that the note is received (in mysql message_queue) but the to_address is the patron's email - this is wrong 4) Apply patch and refresh OPAC 5) Leave a note on a checkout 6) Confirm that the note is received in message queue 7) Confirm that the to_address is one of: - branch email - branch reply to - syspref ReplytoDefault - syspref KohaAdminEmailAddress 8) Confirm that the from_address is one of: - patron email - patron emailpro - patron B_email Sponsored-by: Catalyst IT Created attachment 69455 [details] [review] Bug 19496: Fixing to_address for patron notes This patch ensures the patron note to_address is the branch email or the Koha Admin email, and the from_address is the patron's email. To test: 1) Ensure syspref 'allowcheckoutnotes' is turned on 2) Go to OPAC, leave a note on a checkout 3) Confirm that the note is received (in mysql message_queue) but the to_address is the patron's email - this is wrong 4) Apply patch and refresh OPAC 5) Leave a note on a checkout 6) Confirm that the note is received in message queue 7) Confirm that the to_address is one of: - branch email - branch reply to - syspref ReplytoDefault - syspref KohaAdminEmailAddress 8) Confirm that the from_address is one of: - patron email - patron emailpro - patron B_email Sponsored-by: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Created attachment 69606 [details] [review] Bug 19496: Fixing to_address for patron notes This patch ensures the patron note to_address is the branch email or the Koha Admin email, and the from_address is the patron's email. To test: 1) Ensure syspref 'allowcheckoutnotes' is turned on 2) Go to OPAC, leave a note on a checkout 3) Confirm that the note is received (in mysql message_queue) but the to_address is the patron's email - this is wrong 4) Apply patch and refresh OPAC 5) Leave a note on a checkout 6) Confirm that the note is received in message queue 7) Confirm that the to_address is one of: - branch email - branch reply to - syspref ReplytoDefault - syspref KohaAdminEmailAddress 8) Confirm that the from_address is one of: - patron email - patron emailpro - patron B_email Sponsored-by: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 69611 [details] [review] Bug 19496: ReplytoDefault is a pref, not a C4::Context method I expect that librarians will get spammed. But as soon as it fixed a major bug I am going to push this patch. We should generate a digest for these PATRON_NOTE notice. See also bug 19772 I found when testing this patch. Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.01, awesome work all! Patch does not apply to 17.05.x because it is still $member hash instead of $patron object. Rebase looks tricky, please provide rebased patches. Created attachment 70012 [details] [review] Bug 19496: [17.05.x] Fixing to_address for patron notes This patch ensures the patron note to_address is the branch email or the Koha Admin email, and the from_address is the patron's email. To test: 1) Ensure syspref 'allowcheckoutnotes' is turned on 2) Go to OPAC, leave a note on a checkout 3) Confirm that the note is received (in mysql message_queue) but the to_address is the patron's email - this is wrong 4) Apply patch and refresh OPAC 5) Leave a note on a checkout 6) Confirm that the note is received in message queue 7) Confirm that the to_address is one of: - branch email - branch reply to - syspref ReplytoDefault - syspref KohaAdminEmailAddress 8) Confirm that the from_address is one of: - patron email - patron emailpro - patron B_email Sponsored-by: Catalyst IT Created attachment 70013 [details] [review] Bug 19496: [17.05.x] ReplytoDefault is a pref, not a C4::Context method (In reply to Fridolin SOMERS from comment #9) > Patch does not apply to 17.05.x because it is still $member hash instead of > $patron object. > Rebase looks tricky, please provide rebased patches. Done, please test! (In reply to Jonathan Druart from comment #12) > (In reply to Fridolin SOMERS from comment #9) > > Patch does not apply to 17.05.x because it is still $member hash instead of > > $patron object. > > Rebase looks tricky, please provide rebased patches. > > Done, please test! Works perfect thanks a lot Pushed to 17.05.x for 17.05.08 This looks incorrect to me with regards to how email preference fallbacks should work. I'm going to open another bug to clarify - bug 22821 |